details:   https://code.openbravo.com/erp/devel/pi/rev/3948973fcaaf
changeset: 23960:3948973fcaaf
user:      Asier Lostalé <asier.lostale <at> openbravo.com>
date:      Wed Jul 02 11:33:10 2014 +0200
summary:   fixed bug 26980: order is not kept when exporting to csv

  When toggling sorting (asc-desc) in a FK property and grid is exported to csv,
  sorting is not preserved.

  The problem is caused by SC's ListGrid.getSortField which is returning null in
  this situation. This fix prevents using this function using getSort which 
works
  correctly.

diffstat:

 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
 |  12 ++++-----
 1 files changed, 5 insertions(+), 7 deletions(-)

diffs (22 lines):

diff -r 86cac6cfedd2 -r 3948973fcaaf 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
--- 
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
  Thu Jul 03 06:35:09 2014 +0200
+++ 
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
  Wed Jul 02 11:33:10 2014 +0200
@@ -924,13 +924,11 @@
       _textMatchStyle: 'substring',
       _UTCOffsetMiliseconds: OB.Utilities.Date.getUTCOffsetInMiliseconds()
     }, lcriteria, this.getFetchRequestParams(null, isExporting));
-    if (this.getSortField()) {
-      sortCriteria = this.getSort();
-      if (sortCriteria && sortCriteria.length > 0) {
-        d._sortBy = sortCriteria[0].property;
-        if (sortCriteria[0].direction === 'descending') {
-          d._sortBy = '-' + d._sortBy;
-        }
+    sortCriteria = this.getSort();
+    if (sortCriteria && sortCriteria.length > 0) {
+      d._sortBy = sortCriteria[0].property;
+      if (sortCriteria[0].direction === 'descending') {
+        d._sortBy = '-' + d._sortBy;
       }
     }
     OB.Utilities.postThroughHiddenForm(dsURL, d);

------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to