details: https://code.openbravo.com/erp/devel/pi/rev/4abfea80b24b changeset: 24291:4abfea80b24b user: Augusto Mauch <augusto.mauch <at> openbravo.com> date: Thu Aug 21 14:11:31 2014 +0200 summary: Fixes issue 27407: System info window can not be edited
The problem was that a code introduced here [1] assumed that the startRow and endRow parameters were not null. When the ComboTableData.select method is invoked for lists, both parameters are null. [1] https://code.openbravo.com/erp/devel/pi/rev/a496e0ae760c8270868810311fa9df01794fec98 diffstat: src/org/openbravo/erpCommon/utility/ComboTableData.java | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diffs (19 lines): diff -r 4e55d4ef021a -r 4abfea80b24b src/org/openbravo/erpCommon/utility/ComboTableData.java --- a/src/org/openbravo/erpCommon/utility/ComboTableData.java Thu Aug 21 11:35:54 2014 +0530 +++ b/src/org/openbravo/erpCommon/utility/ComboTableData.java Thu Aug 21 14:11:31 2014 +0200 @@ -1189,7 +1189,14 @@ result.close(); if (includeActual && actual != null && !actual.equals("") && !idFound) { - boolean allDataInSinglePage = startRow == 0 && vector.size() < endRow - startRow; + boolean allDataInSinglePage; + if (startRow != null && endRow != null) { + allDataInSinglePage = startRow == 0 && vector.size() < endRow - startRow; + } else { + // This method is invoked with startRow = endRow = null for lists. Lists always have load + // all data in a single page + allDataInSinglePage = true; + } if (!allDataInSinglePage) { // retrieved a partial set of data, checking if current id is in a page different that the // served applying the same criteria, if so, do not add it again to the list (it will ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ Openbravo-commits mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openbravo-commits
