details: https://code.openbravo.com/erp/devel/pi/rev/edc2a785a7a3
changeset: 24328:edc2a785a7a3
user: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
date: Tue Aug 26 00:36:56 2014 +0200
summary: Fixes issue 25016: NPE when calling process via toolbar button.
This issue fix 2 things:
1a) Do not fail if ph.getResult() is null.
2a) Change message in log4j.error.
diffstat:
src-wad/src/org/openbravo/wad/ActionButtonJava_Responser.javaxml | 10
++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diffs (22 lines):
diff -r 7ddaaea7ae8f -r edc2a785a7a3
src-wad/src/org/openbravo/wad/ActionButtonJava_Responser.javaxml
--- a/src-wad/src/org/openbravo/wad/ActionButtonJava_Responser.javaxml Tue Aug
26 00:50:27 2014 +0530
+++ b/src-wad/src/org/openbravo/wad/ActionButtonJava_Responser.javaxml Tue Aug
26 00:36:56 2014 +0200
@@ -197,12 +197,14 @@
OBError myMessage = null;
try {
<FIELD_TMP id="ProcessCode4">execute process</FIELD_TMP>
- myMessage = (OBError) pb.getResult();
- myMessage.setMessage(Utility.parseTranslation(this, vars,
vars.getLanguage(), myMessage.getMessage()));
- myMessage.setTitle(Utility.parseTranslation(this, vars,
vars.getLanguage(), myMessage.getTitle()));
+ if((OBError)pb.getResult()!=null){
+ myMessage = (OBError) pb.getResult();
+ myMessage.setMessage(Utility.parseTranslation(this, vars,
vars.getLanguage(), myMessage.getMessage()));
+ myMessage.setTitle(Utility.parseTranslation(this, vars,
vars.getLanguage(), myMessage.getTitle()));
+ }
} catch (Exception ex) {
myMessage = Utility.translateError(this, vars, vars.getLanguage(),
ex.getMessage());
- log4j.error(ex);
+ log4j.error("Error calling process", ex);
if (!myMessage.isConnectionAvailable()) {
bdErrorConnection(response);
return;
------------------------------------------------------------------------------
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
