details:   https://code.openbravo.com/erp/devel/pi/rev/43554c8adcf5
changeset: 25018:43554c8adcf5
user:      Stefan Hühner <stefan.huehner <at> openbravo.com>
date:      Tue Oct 07 18:21:15 2014 +0200
summary:   Fixed 27433. Delete trigger without content: S_RESOURCEASSIGNMENT_TRG
This trigger has all of its useful body commented out.
Checking hg history shows that to be the case since revision 0.

details:   https://code.openbravo.com/erp/devel/pi/rev/f65eeca4b228
changeset: 25019:f65eeca4b228
user:      Stefan Hühner <stefan.huehner <at> openbravo.com>
date:      Tue Oct 07 18:25:57 2014 +0200
summary:   Fixed 27434. Deleted useless trigger C_DP_MANAGEMENTLINE_TRG.
All code for this trigger is inside an if :new.status_from == null check
Checking definition of that status_from column in the c_dp_managementline table
shows that it is defined as not null (as has been since hg revision 0).

So that condition can never be true so all the trigger is not useful.

details:   https://code.openbravo.com/erp/devel/pi/rev/18d447125911
changeset: 25020:18d447125911
user:      Stefan Hühner <stefan.huehner <at> openbravo.com>
date:      Tue Oct 07 18:31:19 2014 +0200
summary:   Fixed 27442. Fix uuid bug. redefine v_billto variable as 
varchar2(32).
The variable v_billto is used to store a uuid (value of c_order.billto_id)
so define it as such and not as a number type.

details:   https://code.openbravo.com/erp/devel/pi/rev/c860b3092ded
changeset: 25021:c860b3092ded
user:      Stefan Hühner <stefan.huehner <at> openbravo.com>
date:      Tue Oct 07 18:35:13 2014 +0200
summary:   Fix 27443. Fix uuid bug in pl-function m_inout_updatequantities
The variable v_lines_aux in that pl-function is defined as numeric(10) but is
clearly used to hold uuid.
Redefine it to have correct datatype.

diffstat:

 src-db/database/model/functions/M_COPY_PRODUCT_TEMPLATE.xml  |   2 +-
 src-db/database/model/functions/M_INOUT_UPDATEQUANTITYES.xml |   2 +-
 src-db/database/model/triggers/C_DP_MANAGEMENTLINE_TRG.xml   |  52 ---------
 src-db/database/model/triggers/S_RESOURCEASSIGNMENT_TRG.xml  |  69 ------------
 4 files changed, 2 insertions(+), 123 deletions(-)

diffs (153 lines):

diff -r 553b2d6a7722 -r c860b3092ded 
src-db/database/model/functions/M_COPY_PRODUCT_TEMPLATE.xml
--- a/src-db/database/model/functions/M_COPY_PRODUCT_TEMPLATE.xml       Wed Oct 
08 12:10:58 2014 +0200
+++ b/src-db/database/model/functions/M_COPY_PRODUCT_TEMPLATE.xml       Tue Oct 
07 18:35:13 2014 +0200
@@ -38,7 +38,7 @@
     v_Org VARCHAR2(32);
     v_Createdby VARCHAR2(32);
     v_Dateordered DATE;
-    v_BillTo NUMBER;
+    v_BillTo VARCHAR2(32);
     v_BpartnerLocation VARCHAR2(32);
     v_Pricelist VARCHAR2(32);
     v_Pricelimit NUMBER;
diff -r 553b2d6a7722 -r c860b3092ded 
src-db/database/model/functions/M_INOUT_UPDATEQUANTITYES.xml
--- a/src-db/database/model/functions/M_INOUT_UPDATEQUANTITYES.xml      Wed Oct 
08 12:10:58 2014 +0200
+++ b/src-db/database/model/functions/M_INOUT_UPDATEQUANTITYES.xml      Tue Oct 
07 18:35:13 2014 +0200
@@ -114,7 +114,7 @@
       DECLARE
         Cur_Lines RECORD;
         v_Lines VARCHAR2(4000):='';
-        v_Lines_Aux NUMBER(10) ;
+        v_Lines_Aux VARCHAR2(32);
         v_StrSQL VARCHAR2(4000):='';
       BEGIN
         FOR Cur_Lines IN
diff -r 553b2d6a7722 -r c860b3092ded 
src-db/database/model/triggers/C_DP_MANAGEMENTLINE_TRG.xml
--- a/src-db/database/model/triggers/C_DP_MANAGEMENTLINE_TRG.xml        Wed Oct 
08 12:10:58 2014 +0200
+++ /dev/null   Thu Jan 01 00:00:00 1970 +0000
@@ -1,52 +0,0 @@
-<?xml version="1.0"?>
-  <database name="TRIGGER C_DP_MANAGEMENTLINE_TRG">
-    <trigger name="C_DP_MANAGEMENTLINE_TRG" table="C_DP_MANAGEMENTLINE" 
fires="before" insert="true" update="true" delete="false" foreach="row">
-      <body><![CDATA[
-
-
-
-
-/*************************************************************************
-* The contents of this file are subject to the Openbravo  Public  License
-* Version  1.1  (the  "License"),  being   the  Mozilla   Public  License
-* Version 1.1  with a permitted attribution clause; you may not  use this
-* file except in compliance with the License. You  may  obtain  a copy of
-* the License at http://www.openbravo.com/legal/license.html
-* Software distributed under the License  is  distributed  on  an "AS IS"
-* basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See the
-* License for the specific  language  governing  rights  and  limitations
-* under the License.
-* The Original Code is Openbravo ERP.
-* The Initial Developer of the Original Code is Openbravo SLU
-* All portions are Copyright (C) 2001-2006 Openbravo SLU
-* All Rights Reserved.
-* Contributor(s):  ______________________________________.
-************************************************************************/
-    
-BEGIN
-    
-    IF AD_isTriggerEnabled()='N' THEN RETURN;
-    END IF;
-
-
-  IF (INSERTING) THEN
-    IF (:NEW.status_from IS NULL) THEN
-    BEGIN
-
-        SELECT status
-          INTO :NEW.status_from
-          FROM c_debt_payment
-        WHERE c_debt_payment_id = :NEW.c_debt_payment_id;
-      EXCEPTION
-        WHEN NO_DATA_FOUND THEN
-          :NEW.status_from := 'DE';
-    END;
-    END IF;
-  END IF;
-EXCEPTION
-  WHEN OTHERS THEN
-    NULL;
-END C_DP_MANAGEMENTLINE_TRG
-]]></body>
-    </trigger>
-  </database>
diff -r 553b2d6a7722 -r c860b3092ded 
src-db/database/model/triggers/S_RESOURCEASSIGNMENT_TRG.xml
--- a/src-db/database/model/triggers/S_RESOURCEASSIGNMENT_TRG.xml       Wed Oct 
08 12:10:58 2014 +0200
+++ /dev/null   Thu Jan 01 00:00:00 1970 +0000
@@ -1,69 +0,0 @@
-<?xml version="1.0"?>
-  <database name="TRIGGER S_RESOURCEASSIGNMENT_TRG">
-    <trigger name="S_RESOURCEASSIGNMENT_TRG" table="S_RESOURCEASSIGNMENT" 
fires="after" insert="true" update="true" delete="true" foreach="row">
-      <body><![CDATA[
-    /*************************************************************************
-    * The contents of this file are subject to the Compiere Public
-    * License 1.1 ("License"); You may not use this file except in
-    * compliance with the License. You may obtain a copy of the License in
-    * the legal folder of your Openbravo installation.
-    * Software distributed under the License is distributed on an
-    * "AS IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-    * implied. See the License for the specific language governing rights
-    * and limitations under the License.
-    * The Original Code is  Compiere  ERP &  Business Solution
-    * The Initial Developer of the Original Code is Jorg Janke and ComPiere, 
Inc.
-    * Portions created by Jorg Janke are Copyright (C) 1999-2001 Jorg Janke,
-    * parts created by ComPiere are Copyright (C) ComPiere, Inc.;
-    * All Rights Reserved.
-    * Contributor(s): Openbravo SLU
-    * Contributions are Copyright (C) 2001-2008 Openbravo, S.L.U.
-    *
-    * Specifically, this derivative work is based upon the following Compiere
-    * file and version.
-    *************************************************************************
-    * $Id: S_ResourceAssignment_Trg.sql,v 1.2 2003/03/19 06:46:56 jjanke Exp $
-    ***
-    * Title: S_Resource Assignment
-    * Description:
-    *   Syncronize Resource Assugnment with Expense Reports
-    ************************************************************************/
-    v_Description NVARCHAR2(255) ;
-    
-BEGIN
-    
-    IF AD_isTriggerEnabled()='N' THEN RETURN;
-    END IF;
-
-
-  NULL;
-  /**
-  IF (INSERTING OR UPDATING) THEN
-  v_Description:=:new.Name;
-  IF (:new.Description IS NOT NULL AND LENGTH(:new.Description) > 0) THEN
-  v_Description:=v_Description || ' (' || :new.Description || ')';
-  END IF;
-  -- Update Expense Line
-  UPDATE S_TimeExpenseLine
-  SET  Description=v_Description,
-  Qty=:new.Qty
-  WHERE S_ResourceAssignment_ID=:new.S_ResourceAssignment_ID
-  AND (Description <> v_Description OR Qty <> :new.Qty);
-  -- Update Order Line
-  UPDATE C_OrderLine
-  SET  Description=v_Description,
-  QtyOrdered=:new.Qty
-  WHERE S_ResourceAssignment_ID=:new.S_ResourceAssignment_ID
-  AND (Description <> v_Description OR QtyOrdered <> :new.Qty);
-  -- Update Invoice Line
-  UPDATE C_InvoiceLine
-  SET  Description=v_Description,
-  QtyInvoiced=:new.Qty
-  WHERE S_ResourceAssignment_ID=:new.S_ResourceAssignment_ID
-  AND (Description <> v_Description OR QtyInvoiced <> :new.Qty);
-  END IF;
-  **/
-END S_RESOURCEASSIGNMENT_TRG
-]]></body>
-    </trigger>
-  </database>

------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to