details: https://code.openbravo.com/erp/devel/pi/rev/54218273885c
changeset: 26267:54218273885c
user: Asier Lostalé <asier.lostale <at> openbravo.com>
date: Thu Mar 26 11:31:57 2015 +0100
summary: fixed issue 29426: unneeded param in callback for client side
validation
Callback function sent to client side validation had a mandatory view paramter
that required to be the same one as the received one.
This paramter has been removed
diffstat:
modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
| 2 +-
modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js
| 8 ++--
modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-findTransaction.js
| 6 ++--
modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js
| 2 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
| 14 +++++-----
web/js/validateCostingRuleProcess.js
| 4 +-
6 files changed, 18 insertions(+), 18 deletions(-)
diffs (138 lines):
diff -r 9216d290b2f2 -r 54218273885c
modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
a/modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
Thu Mar 26 10:26:30 2015 +0100
+++
b/modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
Thu Mar 26 11:31:57 2015 +0100
@@ -1156,7 +1156,7 @@
return clientSideValidationFail();
}
}
- actionHandlerCall(view);
+ actionHandlerCall();
};
OB.RemoteCallManager.call('org.openbravo.advpaymentmngt.actionHandler.AddPaymentOnProcessActionHandler',
{
diff -r 9216d290b2f2 -r 54218273885c
modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js
---
a/modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js
Thu Mar 26 10:26:30 2015 +0100
+++
b/modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js
Thu Mar 26 11:31:57 2015 +0100
@@ -35,7 +35,7 @@
execute = function (ok) {
if (ok) {
- actionHandlerCall(view);
+ actionHandlerCall();
} else {
clientSideValidationFail();
}
@@ -59,16 +59,16 @@
// Split required
if (hideSplitConfirmation === 'Y') {
// Continue with the match
- actionHandlerCall(view);
+ actionHandlerCall();
} else {
isc.confirm(OB.I18N.getLabel('APRM_SplitBankStatementLineConfirm'),
execute);
}
} else {
// Continue with the match
- actionHandlerCall(view);
+ actionHandlerCall();
}
} else {
- actionHandlerCall(view);
+ actionHandlerCall();
}
};
diff -r 9216d290b2f2 -r 54218273885c
modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-findTransaction.js
---
a/modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-findTransaction.js
Thu Mar 26 10:26:30 2015 +0100
+++
b/modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-findTransaction.js
Thu Mar 26 11:31:57 2015 +0100
@@ -24,7 +24,7 @@
execute = function (ok) {
if (ok) {
- actionHandlerCall(view);
+ actionHandlerCall();
} else {
clientSideValidationFail();
}
@@ -44,7 +44,7 @@
// Split required
if (hideSplitConfirmation === 'Y') {
// Continue with the match
- actionHandlerCall(view);
+ actionHandlerCall();
} else {
if (isc.isA.emptyObject(OB.TestRegistry.registry)) {
isc.confirm(OB.I18N.getLabel('APRM_SplitBankStatementLineConfirm'), execute);
@@ -54,7 +54,7 @@
}
} else {
// Continue with the match
- actionHandlerCall(view);
+ actionHandlerCall();
}
} else {
// No Transaction selected
diff -r 9216d290b2f2 -r 54218273885c
modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js
---
a/modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js
Thu Mar 26 10:26:30 2015 +0100
+++
b/modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js
Thu Mar 26 11:31:57 2015 +0100
@@ -60,7 +60,7 @@
var execute;
execute = function (ok) {
if (ok) {
- actionHandlerCall(view);
+ actionHandlerCall();
} else {
view.parentElement.parentElement.closeClick();
}
diff -r 9216d290b2f2 -r 54218273885c
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
Thu Mar 26 10:26:30 2015 +0100
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
Thu Mar 26 11:31:57 2015 +0100
@@ -553,12 +553,12 @@
// allow to add external parameters
isc.addProperties(allProperties._params, this.externalParams);
- actionHandlerCall = function (me) {
- me.showProcessing(true);
- OB.RemoteCallManager.call(me.actionHandler, allProperties, {
- processId: me.processId,
- reportId: me.reportId,
- windowId: me.windowId
+ actionHandlerCall = function () {
+ view.showProcessing(true);
+ OB.RemoteCallManager.call(view.actionHandler, allProperties, {
+ processId: view.processId,
+ reportId: view.reportId,
+ windowId: view.windowId
}, function (rpcResponse, data, rpcRequest) {
view.handleResponse(!(data && data.refreshParent === false), (data &&
data.message), (data && data.responseActions), (data && data.retryExecution),
data);
});
@@ -570,7 +570,7 @@
};
this.clientSideValidation(this, actionHandlerCall,
clientSideValidationFail);
} else {
- actionHandlerCall(this);
+ actionHandlerCall();
}
},
diff -r 9216d290b2f2 -r 54218273885c web/js/validateCostingRuleProcess.js
--- a/web/js/validateCostingRuleProcess.js Thu Mar 26 10:26:30 2015 +0100
+++ b/web/js/validateCostingRuleProcess.js Thu Mar 26 11:31:57 2015 +0100
@@ -30,7 +30,7 @@
callbackOnProcessActionHandler = function (response, data, request) {
execute = function (ok) {
if (ok) {
- actionHandlerCall(view);
+ actionHandlerCall();
} else {
view.parentElement.parentElement.closeClick();
}
@@ -38,7 +38,7 @@
if (data.message.text) {
isc.confirm(data.message.text, execute);
} else {
- actionHandlerCall(view);
+ actionHandlerCall();
}
};
view.messageBar.setMessage(isc.OBMessageBar.TYPE_INFO, null,
OB.I18N.getLabel('CostingRuleHelp'));
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
