details: https://code.openbravo.com/erp/devel/main/rev/30bf98d9525d changeset: 26389:30bf98d9525d user: Unai Martirena <unai.martirena <at> openbravo.com> date: Tue Mar 31 13:11:57 2015 +0200 summary: Fixed bug 29471: Invoice's entry Currency Balancing instead of Vendor Prepayment
The selectPrepayments method now searches by FIN_PAYMENT_SCHEDULEDETAIL.FIN_PAYMENT_SCHEDULE_ORDER instead of FIN_PAYMENT_SCHEDULEDETAIL.FIN_PAYMENT_SCHEDULE_INVOICE, because a prepayment is linked to an order. details: https://code.openbravo.com/erp/devel/main/rev/d80a1e60b2e0 changeset: 26390:d80a1e60b2e0 user: Unai Martirena <unai.martirena <at> openbravo.com> date: Wed Mar 04 16:09:33 2015 +0100 summary: Fixes bug 29487: Performance improved in Costing Background process. There are two methods in Costing Background process in which an ScrollableResult is built and iterated. 'setCalculatedTransactionsAsProcessed' and 'setCalculatedTransactionsAsProcessed'. This loops where causing Out of memory issues because they were not flushing and clearing session every little amount of iterations. Apart from this, the two ScrollableResults were leaving opened, which may cause lot of issues especially in Oracle. Finally, these methods have been implemented in another way. Directly updating all the records on a single update in hql. In this way the performance is improved even adding flush and clear on the previously loops. details: https://code.openbravo.com/erp/devel/main/rev/235571f94428 changeset: 26391:235571f94428 user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> date: Tue Mar 31 16:47:42 2015 +0200 summary: Fixes issue 29480: Lines shown when filtering by a wrong value Lines will not be shown, if they are not checked, when filtering by a wrong value in a number type column, in Manage Reservation popup details: https://code.openbravo.com/erp/devel/main/rev/e0aaa18a6afa changeset: 26392:e0aaa18a6afa user: Unai Martirena <unai.martirena <at> openbravo.com> date: Wed Apr 01 17:29:41 2015 +0200 summary: Fixes bug 29472: Bank Statement Line amount maintained in Add Payment from FA If exists bslamount this means that Add Payment window has been opened from Match Statement window, so, when selecting a line in Order/Invoices grid, this amount will be set in the line when is smaller than outstanding amount. If Outstanding amount is smaller, then outstanding amount will be assigned. details: https://code.openbravo.com/erp/devel/main/rev/225871f66353 changeset: 26393:225871f66353 user: Asier Lostalé <asier.lostale <at> openbravo.com> date: Tue Mar 31 12:45:26 2015 +0200 summary: fixed bug 29466: list reference are validated while typing This caused to see the field in red as non valid while typing to filter a value. It has been fixed in the same way selector reference does: preventing validation on filterComplete. A new OBComboBoxItem class has been implemented in order to make both list and selectors (including table and tableDir) extend it preventing in this manner code duplicities. details: https://code.openbravo.com/erp/devel/main/rev/e8390419d028 changeset: 26394:e8390419d028 user: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> date: Wed Apr 01 15:55:26 2015 +0200 summary: Fixed bug 29497: Several issues in Match Statement 1) Wrong management of default parameters in automatic execution process: ParameterType was used where InputType was expected (and the opposite) 2) NPE when working with default parameters in execution process constantParameters attribute wasn't initialized before being used. Fixed also parameters attribute with the same potential issue 3) Impossible to create a new payment from transaction when the payment method has an automatic execution process and automatic deposit/withdrawn We now pass an internal parameter "comingFrom" to know if we come from a transaction. In this case we don't create automatically the transaction (regardless the payment method is automatic deposit/withdrawn) to avoid breaking the unique constraint FIN_FINACC_TRANSACTION_UN inside FIN_FINACC_TRANSACTION table details: https://code.openbravo.com/erp/devel/main/rev/fc1c0b8924b8 changeset: 26395:fc1c0b8924b8 user: Unai Martirena <unai.martirena <at> openbravo.com> date: Tue Apr 07 10:06:32 2015 +0200 summary: Related to bu 29497: Code Review Use ParameterType instead of InputType for CONSTANT String. details: https://code.openbravo.com/erp/devel/main/rev/50789d357902 changeset: 26396:50789d357902 user: Jorge Garcia <jorge.garcia <at> openbravo.com> date: Wed Apr 08 11:17:08 2015 +0200 summary: Fixed issue 29504: It is possible to create a payment in/out It is possible to create a payment header when a payment method or a financial account is disabled in a given financial account. Now only active payment methods of financial accounts and active financial accounts are showing in the payment in / payment out window. In addition, if the user selects a business partner in these windows and the default payment method and/or the default financial account is/are inactive, a warning message is shown to the user, indicating which one is inactive. These warning messages are also included in the fix. details: https://code.openbravo.com/erp/devel/main/rev/155824f390cc changeset: 26397:155824f390cc user: Unai Martirena <unai.martirena <at> openbravo.com> date: Thu Apr 09 17:24:48 2015 +0200 summary: Fixes bug 29535: Transaction can be created from Add transaction for Bank Fee details: https://code.openbravo.com/erp/devel/main/rev/5ea2872a6163 changeset: 26398:5ea2872a6163 user: Unai Martirena <unai.martirena <at> openbravo.com> date: Fri Apr 10 08:21:40 2015 +0200 summary: Fixes bug 29474: Cannot be reserved more than available Stock. Few more issues have been fixed also: 1) Prereservation lines will never have Warehouse field filled until they are received. 2) Filter of Purchase Order Line now is working having reservation completed or in draft status. 3) Prereservation Lines are displayed when the reservation is in draft status and they are not still reserved. details: https://code.openbravo.com/erp/devel/main/rev/9eff7a3a2b9d changeset: 26399:9eff7a3a2b9d user: Unai Martirena <unai.martirena <at> openbravo.com> date: Fri Apr 10 11:17:47 2015 +0200 summary: Fixes bug 29541: Payment Out can be reactivated without bp purchase pricelist The problem is that the method 'getConversionRateDocumentForInvoice' tries to get a conversion using the currency of Purchase PriceList of the business partner, and it could happen to be empty, so it fails. Starting from 3.0PR14Q4 the Currency field in the business partner is mandatory, so it can be used for Sales/Purchase flow. It could be that at this point while reactivating the Payment to be the Currency of the Business Partner null, because it was created long time ago and no currency set yet, so, if this is the case an error will be raised to the user in order to fix this. A last change has been made in 'OBMessageUtils.messageBD' method, adding an extra parameter when it is wanted to avoid doing escape of '\n' and doublequotes characters. In this case it is needed because the message that needs to be displayed needs to maintain them because contains a link. This implementation is similar to the one found in BasicUtility.messageBD. details: https://code.openbravo.com/erp/devel/main/rev/820ea30197c5 changeset: 26400:820ea30197c5 user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> date: Mon Apr 13 15:50:26 2015 +0200 summary: Related to issue 29541: Removed unused parameter Removed unused parameter in getConversionRateDocumentForInvoice method details: https://code.openbravo.com/erp/devel/main/rev/4b2d2f209c73 changeset: 26401:4b2d2f209c73 user: Unai Martirena <unai.martirena <at> openbravo.com> date: Mon Apr 13 18:07:27 2015 +0200 summary: Fixes issue 29510: Duplicated amount when cancelled payment Removes canceled payment schedule details when posting. details: https://code.openbravo.com/erp/devel/main/rev/0fe1fb83dabe changeset: 26402:0fe1fb83dabe user: Carlos Aristu <carlos.aristu <at> openbravo.com> date: Tue Apr 14 13:45:24 2015 +0200 summary: fixes issue 29567: onChange event does not work fine using Date parameters in Process Definition There were two different problems: 1) When changing the value manually, the _textChanged attribute was always true after the first change. This prevented the date value to be updated properly. This has been solved by creating a new method, setDateParameterValue, which avoids this problem when setting the date parameter values. The following documentation has been updated with this information: http://wiki.openbravo.com/wiki/How_to_create_a_Standard_Process_Definition#Advanced_Topics 2) When changing the value from the date picker, the onblur event was not being called after the first time. This has been solved by calling the handleItemChange method of the OBParameterWindowForm class after choosing the value from the picker. details: https://code.openbravo.com/erp/devel/main/rev/9da5f0781b8a changeset: 26403:9da5f0781b8a user: Jorge Garcia <jorge.garcia <at> openbravo.com> date: Tue Apr 14 18:24:05 2015 +0200 summary: Fixed issue 29584: It is not possible to reactivate a Landed Cost It is not possible to reactivate a Landed Cost under some circunstances. The problem was fixed from the LandedCostDistributionAlgorithm.java When you try to reactivate a Landed Cost, an error message appears and the process was cancelled Now the process is done succesfully and the Landed Cost can be reactivated. details: https://code.openbravo.com/erp/devel/main/rev/819163009400 changeset: 26404:819163009400 user: Unai Martirena <unai.martirena <at> openbravo.com> date: Tue Apr 14 18:56:15 2015 +0200 summary: Fixes bug 29545: Accounting Date is updated when Transaction Date changes A callout has been added in Transaction Date field of transaction tab under Financial Account. An onchange function has been added in Transaction Date in Add Transaction Process Definition. details: https://code.openbravo.com/erp/devel/main/rev/ba268cfc7d89 changeset: 26405:ba268cfc7d89 user: Asier Lostalé <asier.lostale <at> openbravo.com> date: Thu Apr 16 11:06:30 2015 +0200 summary: fixed bug 29609: System cannot be rebuilt having Tomcat JDBC Pool OBPropertiesProvider.setProperties method was invoked when rebuilding to get a connection, as this method tried to log with INFO level, it caused recursive invokations. Messages logged while setting properties have been lowered to DEBUG to prevent this situation. details: https://code.openbravo.com/erp/devel/main/rev/af63dcb16553 changeset: 26406:af63dcb16553 user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> date: Thu Apr 16 18:33:31 2015 +0200 summary: Fixes issue 29616: Error in GLJournalAccountingCheck validation Query in GLJournalAccountingCheck build validation has been changed to avoid build validation fail, when exists a negative gl journal line and system is configured to "not allow negative amount" during posting, although accounting information is correct details: https://code.openbravo.com/erp/devel/main/rev/a1933ab8b811 changeset: 26407:a1933ab8b811 user: Inigo Sanchez <inigo.sanchez <at> openbravo.com> date: Mon Apr 20 09:31:41 2015 +0200 summary: Fixed bug 29628: setup application is not taking into account the context name The setup application is not taking into account the context name that users are configuring. The values of "deploy-name" and "context-root" properties of org.eclipse.wst.common.component are not updating. Now it has been solved and if user set "context-name" in setup application. this value is updating in org.eclipse.wst.common.component. For example if a user set the context name as "test" the URL to go to Openbravo is "http://localhost:8080/test"; instead of default one "http://localhost:8080/openbravo";. details: https://code.openbravo.com/erp/devel/main/rev/05d86072ac4e changeset: 26408:05d86072ac4e user: Unai Martirena <unai.martirena <at> openbravo.com> date: Mon Apr 20 09:23:09 2015 +0200 summary: Fixes bug 29619: Correctly used credit when paying an invoice and refunding There were two issues while managing this scenario: [1] In 'addCredit' method inside AddPaymentActionHandler.java class, a loop of Credit to Use grid is done, creating Payment Credit Used records assigned to the new created payment of the invoice. This method was not taking into account that could be credit amount that exceeds the invoice amount (amount to be refunded) and it was assigning all the credit amount as used to the payment of the invoice. So the refund payment that is created right after was been left without any used credit payment. [2] After fixing the previous method, the second issue appears. The 'updateUsedCredit' method inside FIN_PaymentProcess.java class retrieves all the payments of the business partner that has generated credit, and it assigns as used to the refund payment. The problem with this function is that before the Add Payment refactor it was not possible to select which credit payments we wanted to consume, it was only a total credit amount to be consumed and the system behind was being consuming any of them. But after the refactor it is possible to select the ones that want to be consumed. In order to fix this last issue the selected credit line ids are added as a parameter to 'updateUsedCredit' method. details: https://code.openbravo.com/erp/devel/main/rev/138f5d1b2791 changeset: 26409:138f5d1b2791 user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> date: Tue Apr 21 11:04:04 2015 +0200 summary: Fixes issue 29633: Foreign currency not setted in transaction When creating a transaction manually from a payment, foreign currency, foreign conversion rate and foreign amount fields were not setted to transaction. Now, they will be setted as in TransactionDao.java, when the transaction is automatically created from the payment. details: https://code.openbravo.com/erp/devel/main/rev/04708c933fdf changeset: 26410:04708c933fdf user: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> date: Tue Apr 21 14:18:22 2015 +0200 summary: Fixed bug 29654: Payment selector now filters by child organizations The payment selector was incorrectly filtering by child organizations because the order of the parameters in the call to the AD_ISORGINCLUDED function was wrong. It now gets all the payments belonging to the organization and any child organization of the tab's organization. details: https://code.openbravo.com/erp/devel/main/rev/3113c105fabc changeset: 26411:3113c105fabc user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> date: Wed Apr 22 14:10:57 2015 +0200 summary: Fixes issue 29659: GLItem lost in Add new Transaction window Neither payment nor glitem will be deleted when changing to Bank fee in Add new Transaction window. Instead, when clicking on Done and creating the transaction, AddTransactionActionHandler will check if the transaction is of type Bank fee and in this case it will set as null both fields. details: https://code.openbravo.com/erp/devel/main/rev/816430d1ba95 changeset: 26412:816430d1ba95 user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> date: Thu Apr 23 12:44:09 2015 +0200 summary: Fixes issue 29644: BP selector in AddTransaction shows all bp "Business Partner selector" selector of "Business Partner" paramenter in "AddTransaction" process definition, has been changed into "Business Partner selector without default expressions" selector; in order to show all business partners in the dropdown of the selector. details: https://code.openbravo.com/erp/devel/main/rev/625cbe585797 changeset: 26413:625cbe585797 user: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> date: Thu Apr 23 15:43:27 2015 +0200 summary: Related to issue 29644: changed column in selector field to get the right name, description and help for the selector's column details: https://code.openbravo.com/erp/devel/main/rev/1342ece3ecd9 changeset: 26414:1342ece3ecd9 user: Unai Martirena <unai.martirena <at> openbravo.com> date: Thu Apr 23 10:18:37 2015 +0200 summary: Fixes bug 29677: Fix NPE in Costing Background with Standard Costing Rule In Cost Adjustment project new method has been added to calculate an opening inventory cost. This method uses 'CostinUtils.getStandardCostDefinition' method, that tries to get an standard cost for that opening inventory. If it does not found any standard or legacy cost, it returns null. So, in this moment a NPE error was happening. To fix this problem, at this point a controlled error is raised to notify the user that no cost has been found. details: https://code.openbravo.com/erp/devel/main/rev/c550fb5def49 changeset: 26415:c550fb5def49 user: Jorge Garcia <jorge.garcia <at> openbravo.com> date: Tue Apr 28 09:37:16 2015 +0200 summary: Fixed issue 29704: Description field is set with "null" in the FA Transaction Description field is filled in with "null" in the FA Transaction when matched to GL Item. The problem was in the Match Statement process, more specifically, in the Add new transaction button. The AddTransanctionActionHandler didn't take in consideration that the received description could be null. The fix for this issue is to check if the received description is null or blank. Now, the description field fill in the correct description. details: https://code.openbravo.com/erp/devel/main/rev/e8bf5ea8a038 changeset: 26416:e8bf5ea8a038 user: David Baz Fayos <david.baz <at> openbravo.com> date: Tue Apr 28 12:07:49 2015 +0200 summary: Fixed issue 29691: DateTime now works ok with 12:XX:XX times The root of the problem was that there was a 'typo' and the 'minus' sign was missing in the 'if' statement in charge of evaluate if it was in 24h mode or not. This was used later to substract 12h to the entered date if this was in the 12:XX:XX form, change that obviously doesn't apply in the 24h mode details: https://code.openbravo.com/erp/devel/main/rev/ec7a0bfc9a3c changeset: 26417:ec7a0bfc9a3c user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> date: Tue Apr 28 17:08:24 2015 +0200 summary: Fixes issue 29721: Payment navigation from Transaction tab is working wrong Issotrx auxiliary input query in Transaction tab has been changed to get into account related payment isreceipt field, when navigating from it to Payment In/Out window Also, SE_Payment_Transaction and SE_Trxtype_Transaction callouts have been changed to overwrite issotrx session value when updating payment or transactiontype fields details: https://code.openbravo.com/erp/devel/main/rev/5aa20cf4d18e changeset: 26418:5aa20cf4d18e user: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com> date: Wed Apr 29 14:16:44 2015 +0200 summary: Fixes issue 29726: Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh. Cancel button has been removed as it was considered confusing. Now there are two buttons, one for closing the window called 'OK', as it was before, and another one called 'Reconcile'. Both triggers refresh. Messages have been added to improve user understanding on how the window works. New message to inform the user any change will be persisted. This message can be disabled once clear and will not popup again. Message to run algorithm as well improved. details: https://code.openbravo.com/erp/devel/main/rev/d593b9e93b66 changeset: 26419:d593b9e93b66 user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> date: Wed Apr 29 13:56:15 2015 +0200 summary: Fixes issue 29735: Wrong accounting in Cost Adjusment Wrong accounting of the cost adjusment lines in case of Goods Movement From. In this case, accounting should consider negative amounts, in order to have a net effect of the goods movement adjustment accounting as 0. details: https://code.openbravo.com/erp/devel/main/rev/f30b59323b06 changeset: 26420:f30b59323b06 user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> date: Wed Apr 29 16:35:18 2015 +0200 summary: Related to issue 29735: Modify TestCosting tests Modify GM11, GM12, GM13 and GM5 tests, where cost adjustments from goods movements are created, to update accounting amounts details: https://code.openbravo.com/erp/devel/main/rev/6f1dbff918d9 changeset: 26421:6f1dbff918d9 user: Inigo Sanchez <inigo.sanchez <at> openbravo.com> date: Mon May 04 14:01:49 2015 +0200 summary: Fixed bug 29759:Problems with inherited permissions in process definition The problem was that when a process containing parameters defined as "window" is launched , this manual role has not access to windows contained in that process definition. The cause of this issue is that before 14Q3, no security check was done on P&E grids, so data always was retrieved. >From 15Q1, security is checked requiring explicit access to P&E grid. The issue is fixed by inheriting access from the process, this is if the process is accessible the grid within the P&E doesn't require to have explicit access but inherits from the process itself. details: https://code.openbravo.com/erp/devel/main/rev/dd217f5713f0 changeset: 26422:dd217f5713f0 user: Jorge Garcia <jorge.garcia <at> openbravo.com> date: Tue May 05 13:38:44 2015 +0200 summary: Fixed issue 29777: Header of warehouse picking module do not refresh Header of warehouse picking module do not refresh in some circunstances. Issue of platform. The problem was that the toolbar didn't update when the Manage Incidences process finished. The solution is to update the toolbar when the ActionHandler return the responded JSON. details: https://code.openbravo.com/erp/devel/main/rev/4239774eb8de changeset: 26423:4239774eb8de user: RM packaging bot <staff.rm <at> openbravo.com> date: Tue May 05 12:23:52 2015 +0000 summary: Update AD_MODULE version to 3.0PR15Q2 details: https://code.openbravo.com/erp/devel/main/rev/ac761ac78f57 changeset: 26424:ac761ac78f57 user: RM packaging bot <staff.rm <at> openbravo.com> date: Tue May 05 12:23:52 2015 +0000 summary: Added tag 3.0PR15Q2 for changeset 4239774eb8de details: https://code.openbravo.com/erp/devel/main/rev/8a9b6695238a changeset: 26425:8a9b6695238a user: RM packaging bot <staff.rm <at> openbravo.com> date: Tue May 05 12:23:52 2015 +0000 summary: Added signature for changeset ac761ac78f57 details: https://code.openbravo.com/erp/devel/main/rev/57aa62564121 changeset: 26426:57aa62564121 user: RM packaging bot <staff.rm <at> openbravo.com> date: Wed May 06 16:31:31 2015 +0000 summary: Merge temporary head for 3.0PR15Q2 diffstat: .hgsigs | 2 ++ .hgtags | 2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diffs (18 lines): diff -r 3521390ae28e -r 57aa62564121 .hgsigs --- a/.hgsigs Wed Apr 01 06:01:53 2015 +0000 +++ b/.hgsigs Wed May 06 16:31:31 2015 +0000 @@ -167,3 +167,5 @@ 8651cad68d86877ad8a90a0f16ce994daca4c2c3 0 iEYEABECAAYFAlTLW8EACgkQCX/oGf+2qkPEPQCghnkxkVcLRQ5txQCvPqDfmX3OpWAAoOt8wvHw9mJLINJfaStIwhdZ062z 831f7c3e542951b324cd9880b198bb4751bfd251 0 iEYEABECAAYFAlTm9ToACgkQCX/oGf+2qkPpFgCgzIKSAc1CMJoGRySzaUNdjoiyXyUAn2N/WoGlO000oJ6LcEcBldIz3+iT 295e0a259f619311101efee9f1d31aede5bdaa95 0 iEYEABECAAYFAlUZK3oACgkQCX/oGf+2qkOrywCdFORG9mDgA9SMY95tQrtMYtUftS0AoK6d8rFNeUz9xDvAP/y0B+2myvoN +4d63b001f63758b1b79b9502621754878acdfdff 0 iEYEABECAAYFAlUwx7cACgkQCX/oGf+2qkOn2gCcCxKfDDCR1P8qYR9bNtxTIs81JY8AniiMcNvRgeOQ6DOF+jHHVksUM4eO +ac761ac78f576cee64046e115ac42d2a3b227682 0 iEYEABECAAYFAlVItlgACgkQCX/oGf+2qkPgSACeNz58xoUWpTvMywmncbWx7+r7bnUAn1Ba1al80Q9HMY/wiMNu1Vfpd9Jo diff -r 3521390ae28e -r 57aa62564121 .hgtags --- a/.hgtags Wed Apr 01 06:01:53 2015 +0000 +++ b/.hgtags Wed May 06 16:31:31 2015 +0000 @@ -178,3 +178,5 @@ 17ffddb263ab6fcea496938be6eb10b8c5c53729 3.0PR15Q1 39f3bed2ed0eaa2a7e69a46d7bf417c346e25a6a 3.0PR15Q1.1 31dfe7896f8fcd9390b979d7c6972f5aea00d199 3.0PR15Q1.2 +ad409516bfa0b1c6f7ab128cab4526dd5058c787 3.0PR15Q1.3 +4239774eb8de8f0740bfbd6e3e36c075ee2a5a91 3.0PR15Q2 ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Openbravo-commits mailing list Openbravo-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-commits
