details:   https://code.openbravo.com/erp/devel/pi/rev/dbdd3e64a7d1
changeset: 27029:dbdd3e64a7d1
user:      Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
date:      Tue Jun 23 18:35:47 2015 +0200
summary:   Fixes issue 30212: Wrong error message when posting an invoice

Wrong error message was shown when posting an invoice with a deferred revenue 
in a closed period.
Now, PeriodNotAvailable error message will be shown.

diffstat:

 src/org/openbravo/erpCommon/ad_forms/AcctServer.java |  2 ++
 src/org/openbravo/erpCommon/ad_forms/DocInvoice.java |  3 ++-
 2 files changed, 4 insertions(+), 1 deletions(-)

diffs (32 lines):

diff -r 48fee56d37da -r dbdd3e64a7d1 
src/org/openbravo/erpCommon/ad_forms/AcctServer.java
--- a/src/org/openbravo/erpCommon/ad_forms/AcctServer.java      Wed Jun 24 
14:03:00 2015 +0000
+++ b/src/org/openbravo/erpCommon/ad_forms/AcctServer.java      Tue Jun 23 
18:35:47 2015 +0200
@@ -1115,6 +1115,8 @@
         setMessageResult(OBMessageUtils.translateError(strMessageError));
         if ("@NotConvertible@".equals(strMessageError)) {
           return STATUS_NotConvertible;
+        } else if (StringUtils.equals(strMessageError, 
"@PeriodNotAvailable@")) {
+          return STATUS_PeriodClosed;
         }
       }
       return STATUS_Error;
diff -r 48fee56d37da -r dbdd3e64a7d1 
src/org/openbravo/erpCommon/ad_forms/DocInvoice.java
--- a/src/org/openbravo/erpCommon/ad_forms/DocInvoice.java      Wed Jun 24 
14:03:00 2015 +0000
+++ b/src/org/openbravo/erpCommon/ad_forms/DocInvoice.java      Tue Jun 23 
18:35:47 2015 +0200
@@ -28,6 +28,7 @@
 
 import org.apache.commons.lang.StringUtils;
 import org.apache.log4j.Logger;
+import org.openbravo.base.exception.OBException;
 import org.openbravo.base.secureApp.VariablesSecureApp;
 import org.openbravo.client.kernel.RequestContext;
 import org.openbravo.dal.core.OBContext;
@@ -1194,7 +1195,7 @@
             DocumentType, AD_Org_ID, 
OBDateUtils.formatDate(period.getEndingDate()));
         if ("".equals(data[0].period)) {
           setStatus(STATUS_PeriodClosed);
-          throw new IllegalStateException("DocInvoice - Error getting next 
year period");
+          throw new OBException("@PeriodNotAvailable@");
         }
       } catch (ServletException e) {
         log4j.warn("DocInvoice - Error checking period open.", e);

------------------------------------------------------------------------------
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors 
network devices and physical & virtual servers, alerts via email & sms 
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to