details: https://code.openbravo.com/erp/devel/pi/rev/0c9a6c3e2277
changeset: 27047:0c9a6c3e2277
user: Stefan Hühner <stefan.huehner <at> openbravo.com>
date: Mon Jun 29 17:28:49 2015 +0200
summary: Fixed 30282: Suppress 'unused object allocation' warnings where done
intentionally.
In some cases existing code does create objects without using them just to
check for
side-effects. I.e. new BigDecimal(someString) to check if that string can be
parsed
as a number.
Supress the warning in those cases.
diffstat:
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransaction.java
| 1 +
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/ElementValueEventHandler.java
| 8 ++++----
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/LocationSettingsHandler.java
| 10 ++++------
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/freemarker/FreemarkerTemplateProcessor.java
| 1 +
src-core/src/org/openbravo/base/filter/NumberFilter.java
| 1 +
src/org/openbravo/erpCommon/utility/Utility.java
| 1 +
6 files changed, 12 insertions(+), 10 deletions(-)
diffs (115 lines):
diff -r e147ba9d5635 -r 0c9a6c3e2277
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransaction.java
---
a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransaction.java
Fri Jun 26 13:56:56 2015 +0000
+++
b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransaction.java
Mon Jun 29 17:28:49 2015 +0200
@@ -361,6 +361,7 @@
return ((FIN_ReconciliationLine_v)
obc.uniqueResult()).getTransactionDate();
}
+ @SuppressWarnings("unused")
private void printPage(HttpServletResponse response, VariablesSecureApp
vars, String strOrgId,
String strWindowId, String strTabId, String strPaymentTypeFilter,
String strFinancialAccountId, String reconciliationId, String
strShowCleared,
diff -r e147ba9d5635 -r 0c9a6c3e2277
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/ElementValueEventHandler.java
---
a/modules/org.openbravo.client.application/src/org/openbravo/client/application/event/ElementValueEventHandler.java
Fri Jun 26 13:56:56 2015 +0000
+++
b/modules/org.openbravo.client.application/src/org/openbravo/client/application/event/ElementValueEventHandler.java
Mon Jun 29 17:28:49 2015 +0200
@@ -54,8 +54,8 @@
return entities;
}
- public void onSave(@Observes
- EntityNewEvent event) {
+ @SuppressWarnings("unused")
+ public void onSave(@Observes EntityNewEvent event) {
if (!isValidEvent(event)) {
return;
}
@@ -84,8 +84,7 @@
doIt(account);
}
- public void onUpdate(@Observes
- EntityUpdateEvent event) {
+ public void onUpdate(@Observes EntityUpdateEvent event) {
if (!isValidEvent(event)) {
return;
}
@@ -97,6 +96,7 @@
doIt(account);
}
+ @SuppressWarnings("unused")
private void doIt(ElementValue account) {
boolean isNumber = true;
try {
diff -r e147ba9d5635 -r 0c9a6c3e2277
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/LocationSettingsHandler.java
---
a/modules/org.openbravo.client.application/src/org/openbravo/client/application/event/LocationSettingsHandler.java
Fri Jun 26 13:56:56 2015 +0000
+++
b/modules/org.openbravo.client.application/src/org/openbravo/client/application/event/LocationSettingsHandler.java
Mon Jun 29 17:28:49 2015 +0200
@@ -49,8 +49,7 @@
return entities;
}
- public void onUpdate(@Observes
- EntityUpdateEvent event) {
+ public void onUpdate(@Observes EntityUpdateEvent event) {
if (!isValidEvent(event)) {
return;
}
@@ -59,8 +58,7 @@
instanceCountry.getDateformat());
}
- public void onSave(@Observes
- EntityNewEvent event) {
+ public void onSave(@Observes EntityNewEvent event) {
if (!isValidEvent(event)) {
return;
}
@@ -69,13 +67,13 @@
instanceCountry.getDateformat());
}
- public void onDelete(@Observes
- EntityDeleteEvent event) {
+ public void onDelete(@Observes EntityDeleteEvent event) {
if (!isValidEvent(event)) {
return;
}
}
+ @SuppressWarnings("unused")
private void checkCorrectValues(String numericmask, String datetimeformat,
String dateformat) {
if (numericmask != null) {
if (checkNumericMask(numericmask)) {
diff -r e147ba9d5635 -r 0c9a6c3e2277
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/freemarker/FreemarkerTemplateProcessor.java
---
a/modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/freemarker/FreemarkerTemplateProcessor.java
Fri Jun 26 13:56:56 2015 +0000
+++
b/modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/freemarker/FreemarkerTemplateProcessor.java
Mon Jun 29 17:28:49 2015 +0200
@@ -93,6 +93,7 @@
* @see
*
org.openbravo.client.kernel.TemplateProcessor#validate(org.openbravo.client.kernel.Template)
*/
+ @SuppressWarnings("unused")
public void validate(Template template) throws ValidationException {
try {
final String source = createTemplateSource(template);
diff -r e147ba9d5635 -r 0c9a6c3e2277
src-core/src/org/openbravo/base/filter/NumberFilter.java
--- a/src-core/src/org/openbravo/base/filter/NumberFilter.java Fri Jun 26
13:56:56 2015 +0000
+++ b/src-core/src/org/openbravo/base/filter/NumberFilter.java Mon Jun 29
17:28:49 2015 +0200
@@ -23,6 +23,7 @@
public static final NumberFilter instance = new NumberFilter();
+ @SuppressWarnings("unused")
@Override
public boolean accept(String value) {
try {
diff -r e147ba9d5635 -r 0c9a6c3e2277
src/org/openbravo/erpCommon/utility/Utility.java
--- a/src/org/openbravo/erpCommon/utility/Utility.java Fri Jun 26 13:56:56
2015 +0000
+++ b/src/org/openbravo/erpCommon/utility/Utility.java Mon Jun 29 17:28:49
2015 +0200
@@ -1872,6 +1872,7 @@
* a String
* @return true if the string can be parsed
*/
+ @SuppressWarnings("unused")
public static boolean isBigDecimal(String str) {
try {
new BigDecimal(str.trim());
------------------------------------------------------------------------------
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors
network devices and physical & virtual servers, alerts via email & sms
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
