details: https://code.openbravo.com/erp/devel/pi/rev/2cb16178b888
changeset: 27084:2cb16178b888
user: Atul Gaware <atul.gaware <at> openbravo.com>
date: Thu Jul 02 22:07:27 2015 +0530
summary: Fixes Issue 30273:"Not Balance" error received when posting a
transaction
(although suspense balancing is not needed)
Fix takes into account the payment's sign (payment in/out).
diffstat:
src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diffs (30 lines):
diff -r 22f85795e81f -r 2cb16178b888
src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java
--- a/src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java Mon Jul
06 11:20:55 2015 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java Thu Jul
02 22:07:27 2015 +0530
@@ -798,7 +798,7 @@
if (payment != null) {
if (!payment.getAccount().getCurrency().getId()
.equalsIgnoreCase(payment.getCurrency().getId())) {
- retValue = payment.getAmount();
+ retValue = payment.isReceipt() ? payment.getAmount() :
payment.getAmount().negate();
}
}
if (payment != null) {
@@ -817,7 +817,7 @@
((DocLine_FINFinAccTransaction) p_lines[i]).DepositAmount);
lineBalance = lineBalance.subtract(new BigDecimal(
((DocLine_FINFinAccTransaction) p_lines[i]).PaymentAmount));
- retValue = retValue.add(lineBalance);
+ retValue = retValue.subtract(lineBalance);
} else {
BigDecimal lineBalance = payment.isReceipt() ? new BigDecimal(
((DocLine_FINFinAccTransaction) p_lines[i]).getAmount()) : new
BigDecimal(
@@ -825,7 +825,7 @@
BigDecimal lineWriteoff = payment.isReceipt() ? new BigDecimal(
((DocLine_FINFinAccTransaction) p_lines[i]).getWriteOffAmt()) :
new BigDecimal(
((DocLine_FINFinAccTransaction)
p_lines[i]).getWriteOffAmt()).negate();
- retValue = retValue.add(lineBalance).add(lineWriteoff);
+ retValue = retValue.subtract(lineBalance).subtract(lineWriteoff);
}
}
} finally {
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
