details: https://code.openbravo.com/erp/devel/pi/rev/0159f66bd6e0
changeset: 28542:0159f66bd6e0
user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
date: Thu Jan 21 14:27:39 2016 +0100
summary: Fixes issue 31972: Wrong cost calculation in Costing Migration
Process
HQL in insertTrxCosts method in CostingMigrationProcess class was doing an
inner join between m_transaction and m_inoutline instead of a left join.
diffstat:
src/org/openbravo/costing/CostingMigrationProcess.java | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diffs (21 lines):
diff -r 0171ef423986 -r 0159f66bd6e0
src/org/openbravo/costing/CostingMigrationProcess.java
--- a/src/org/openbravo/costing/CostingMigrationProcess.java Mon Jan 25
10:17:14 2016 +0100
+++ b/src/org/openbravo/costing/CostingMigrationProcess.java Thu Jan 21
14:27:39 2016 +0100
@@ -863,13 +863,12 @@
insert.append(", t." + MaterialTransaction.PROPERTY_TRANSACTIONCOST);
insert.append(", t." +
MaterialTransaction.PROPERTY_TRANSACTIONPROCESSDATE);
insert.append(", t." + MaterialTransaction.PROPERTY_CURRENCY);
- insert.append(", case when t." +
MaterialTransaction.PROPERTY_GOODSSHIPMENTLINE
- + " is null then t." + MaterialTransaction.PROPERTY_MOVEMENTDATE + "
else t."
- + MaterialTransaction.PROPERTY_GOODSSHIPMENTLINE + "."
- + ShipmentInOutLine.PROPERTY_SHIPMENTRECEIPT + "." +
ShipmentInOut.PROPERTY_ACCOUNTINGDATE
- + " end");
+ insert.append(", coalesce(io." + ShipmentInOut.PROPERTY_ACCOUNTINGDATE +
", t."
+ + MaterialTransaction.PROPERTY_MOVEMENTDATE + ")");
insert.append(" from " + TransactionCost.ENTITY_NAME + " as tc ");
insert.append(" right join tc." +
TransactionCost.PROPERTY_INVENTORYTRANSACTION + " as t");
+ insert.append(" left join t." +
MaterialTransaction.PROPERTY_GOODSSHIPMENTLINE + " as iol");
+ insert.append(" left join iol." +
ShipmentInOutLine.PROPERTY_SHIPMENTRECEIPT + " as io");
insert.append(", " + User.ENTITY_NAME + " as u");
insert.append(" where t." + MaterialTransaction.PROPERTY_TRANSACTIONCOST
+ " is not null");
insert.append(" and tc.id is null");
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
