details:   https://code.openbravo.com/erp/devel/pi/rev/6413719aeee5
changeset: 30065:6413719aeee5
user:      Naroa Iriarte <naroa.iriarte <at> openbravo.com>
date:      Mon Sep 12 12:15:22 2016 +0200
summary:   Fixed issue 33799: AD_ROLE_ID was not working fine in the tabs 
display logic

The display logics using the AD_ROLE_ID session variable were not working fine. 
The problem was in the ob-standard-view.js class. The session attributes were 
overwritten with the values saved in the OB.Properties. And in this case it was 
null.
To fix this, a condition has been added, now if the OB.Properties(propertyName) 
is null, the value of the session attribute is not overwritten.

diffstat:

 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
 |  4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diffs (14 lines):

diff -r f4782910908c -r 6413719aeee5 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
--- 
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
 Tue Sep 13 21:47:09 2016 +0000
+++ 
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
 Mon Sep 12 12:15:22 2016 +0200
@@ -231,7 +231,9 @@
     if (this.sessionAttributesNames) {
       this.preferenceValues = {};
       for (i = 0; i < this.sessionAttributesNames.length; i++) {
-        this.preferenceValues[this.sessionAttributesNames[i]] = 
OB.PropertyStore.get(this.sessionAttributesNames[i], 
this.standardWindow.windowId);
+        if (OB.PropertyStore.get(this.sessionAttributesNames[i], 
this.standardWindow.windowId) !== null) {
+          this.preferenceValues[this.sessionAttributesNames[i]] = 
OB.PropertyStore.get(this.sessionAttributesNames[i], 
this.standardWindow.windowId);
+        }
       }
     }
 

------------------------------------------------------------------------------
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to