details: https://code.openbravo.com/erp/devel/pi/rev/789db27692a6 changeset: 30452:789db27692a6 user: Atul Gaware <atul.gaware <at> openbravo.com> date: Tue Jul 28 20:07:53 2015 +0530 summary: Fixes issue 29674: Error posting a payment if no access to Currency window
Change OBContext to admin mode needed before accessing currency objects in isconvertible method of AcctServer class. details: https://code.openbravo.com/erp/devel/pi/rev/543c8285c581 changeset: 30453:543c8285c581 user: Atul Gaware <atul.gaware <at> openbravo.com> date: Tue Jul 28 19:29:28 2015 +0530 summary: Fixes issue 29671: Error in Copy Lines if no access to Currency window Implemented a change in context mode to admin in CopyFromInvoice process. details: https://code.openbravo.com/erp/devel/pi/rev/42b07001fd6a changeset: 30454:42b07001fd6a user: Atul Gaware <atul.gaware <at> openbravo.com> date: Tue Jul 28 20:46:30 2015 +0530 summary: Fixes issue 30018: Invoice Line field in Work Effort should be editable Read only logic in column setting for Invoice Line is removed. details: https://code.openbravo.com/erp/devel/pi/rev/de5fec5ed5b3 changeset: 30455:de5fec5ed5b3 user: Atul Gaware <atul.gaware <at> openbravo.com> date: Fri Jul 31 13:01:32 2015 +0530 summary: Fixes issue 29470: "Last day cut-off" fields should be hidden in Payment Term Last day cut off field is set displayed = no, show in grid = no diffstat: src-db/database/sourcedata/AD_COLUMN.xml | 1 - src-db/database/sourcedata/AD_FIELD.xml | 4 +- src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice.java | 6 +- src/org/openbravo/erpCommon/ad_forms/AcctServer.java | 29 +++++---- 4 files changed, 24 insertions(+), 16 deletions(-) diffs (108 lines): diff -r ab62853b9b6c -r de5fec5ed5b3 src-db/database/sourcedata/AD_COLUMN.xml --- a/src-db/database/sourcedata/AD_COLUMN.xml Mon Oct 10 17:12:47 2016 +0200 +++ b/src-db/database/sourcedata/AD_COLUMN.xml Fri Jul 31 13:01:32 2015 +0530 @@ -206382,7 +206382,6 @@ <!--803278--> <ISPARENT><![CDATA[N]]></ISPARENT> <!--803278--> <ISMANDATORY><![CDATA[N]]></ISMANDATORY> <!--803278--> <ISUPDATEABLE><![CDATA[Y]]></ISUPDATEABLE> -<!--803278--> <READONLYLOGIC><![CDATA[@Processed@='Y' | @Posted@='Y']]></READONLYLOGIC> <!--803278--> <ISIDENTIFIER><![CDATA[Y]]></ISIDENTIFIER> <!--803278--> <SEQNO><![CDATA[100]]></SEQNO> <!--803278--> <ISTRANSLATED><![CDATA[N]]></ISTRANSLATED> diff -r ab62853b9b6c -r de5fec5ed5b3 src-db/database/sourcedata/AD_FIELD.xml --- a/src-db/database/sourcedata/AD_FIELD.xml Mon Oct 10 17:12:47 2016 +0200 +++ b/src-db/database/sourcedata/AD_FIELD.xml Fri Jul 31 13:01:32 2015 +0530 @@ -117749,14 +117749,14 @@ <!--801312--> <AD_TAB_ID><![CDATA[800074]]></AD_TAB_ID> <!--801312--> <AD_COLUMN_ID><![CDATA[801035]]></AD_COLUMN_ID> <!--801312--> <IGNOREINWAD><![CDATA[N]]></IGNOREINWAD> -<!--801312--> <ISDISPLAYED><![CDATA[Y]]></ISDISPLAYED> +<!--801312--> <ISDISPLAYED><![CDATA[N]]></ISDISPLAYED> <!--801312--> <DISPLAYLENGTH><![CDATA[10]]></DISPLAYLENGTH> <!--801312--> <ISREADONLY><![CDATA[N]]></ISREADONLY> <!--801312--> <SEQNO><![CDATA[120]]></SEQNO> <!--801312--> <ISSAMELINE><![CDATA[N]]></ISSAMELINE> <!--801312--> <ISFIELDONLY><![CDATA[N]]></ISFIELDONLY> <!--801312--> <ISENCRYPTED><![CDATA[N]]></ISENCRYPTED> -<!--801312--> <SHOWINRELATION><![CDATA[Y]]></SHOWINRELATION> +<!--801312--> <SHOWINRELATION><![CDATA[N]]></SHOWINRELATION> <!--801312--> <ISFIRSTFOCUSEDFIELD><![CDATA[N]]></ISFIRSTFOCUSEDFIELD> <!--801312--> <AD_MODULE_ID><![CDATA[0]]></AD_MODULE_ID> <!--801312--> <GRID_SEQNO><![CDATA[120]]></GRID_SEQNO> diff -r ab62853b9b6c -r de5fec5ed5b3 src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice.java --- a/src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice.java Mon Oct 10 17:12:47 2016 +0200 +++ b/src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice.java Fri Jul 31 13:01:32 2015 +0530 @@ -11,7 +11,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU - * All portions are Copyright (C) 2001-2012 Openbravo SLU + * All portions are Copyright (C) 2001-2016 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************ @@ -33,6 +33,7 @@ import org.openbravo.base.exception.OBException; import org.openbravo.base.secureApp.HttpSecureAppServlet; import org.openbravo.base.secureApp.VariablesSecureApp; +import org.openbravo.dal.core.OBContext; import org.openbravo.dal.service.OBCriteria; import org.openbravo.dal.service.OBDal; import org.openbravo.erpCommon.businessUtility.Tax; @@ -92,6 +93,7 @@ OBError myError = null; Connection conn = null; try { + OBContext.setAdminMode(true); conn = getTransactionConnection(); CopyFromInvoiceData[] data = CopyFromInvoiceData.select(conn, this, strInvoice, Utility.getContext(this, vars, "#User_Client", windowId), @@ -239,6 +241,8 @@ myError.setTitle(OBMessageUtils.messageBD("Error")); myError.setMessage(OBMessageUtils.messageBD("ProcessRunError")); return myError; + } finally { + OBContext.restorePreviousMode(); } myError = new OBError(); myError.setType("Success"); diff -r ab62853b9b6c -r de5fec5ed5b3 src/org/openbravo/erpCommon/ad_forms/AcctServer.java --- a/src/org/openbravo/erpCommon/ad_forms/AcctServer.java Mon Oct 10 17:12:47 2016 +0200 +++ b/src/org/openbravo/erpCommon/ad_forms/AcctServer.java Fri Jul 31 13:01:32 2015 +0530 @@ -1275,19 +1275,24 @@ if (conversionQuery != null) { conversionCount = conversionQuery.count(); } - if (conversionCount > 0) { - List<ConversionRateDoc> conversionRate = conversionQuery.list(); - OBCriteria<Currency> currencyCrit = OBDal.getInstance().createCriteria(Currency.class); - currencyCrit.add(Restrictions.eq(Currency.PROPERTY_ID, acctSchema.m_C_Currency_ID)); - currencyCrit.setProjection(Projections.max(Currency.PROPERTY_STANDARDPRECISION)); - Long precision = 0L; - if (currencyCrit.count() > 0) { - List<Currency> toCurrency = currencyCrit.list(); - precision = toCurrency.get(0).getStandardPrecision(); + try { + OBContext.setAdminMode(true); + if (conversionCount > 0) { + List<ConversionRateDoc> conversionRate = conversionQuery.list(); + OBCriteria<Currency> currencyCrit = OBDal.getInstance().createCriteria(Currency.class); + currencyCrit.add(Restrictions.eq(Currency.PROPERTY_ID, acctSchema.m_C_Currency_ID)); + currencyCrit.setProjection(Projections.max(Currency.PROPERTY_STANDARDPRECISION)); + Long precision = 0L; + if (currencyCrit.count() > 0) { + List<Currency> toCurrency = currencyCrit.list(); + precision = toCurrency.get(0).getStandardPrecision(); + } + BigDecimal convertedAmount = new BigDecimal("1").multiply(conversionRate.get(0) + .getRate()); + amt = convertedAmount.setScale(precision.intValue(), RoundingMode.HALF_UP).toString(); } - BigDecimal convertedAmount = new BigDecimal("1") - .multiply(conversionRate.get(0).getRate()); - amt = convertedAmount.setScale(precision.intValue(), RoundingMode.HALF_UP).toString(); + } finally { + OBContext.restorePreviousMode(); } if (("").equals(amt) || amt == null) amt = getConvertedAmt("1", currency, acctSchema.m_C_Currency_ID, DateAcct, ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Openbravo-commits mailing list Openbravo-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-commits
