details: https://code.openbravo.com/erp/devel/pi/rev/74a3926b798b
changeset: 30685:74a3926b798b
user: Armaignac <collazoandy4 <at> gmail.com>
date: Mon Nov 21 10:41:15 2016 -0800
summary: Fixes issue 34366: Negative movement quantity in Goods Movements
lines
Do not allow to process a Goods Movements line with negative movement quantity.
If this situation occurs an exception is raised
notifying this error and showing the problematic line.
diffstat:
src-db/database/model/functions/M_MOVEMENT_POST.xml | 4 ++--
src-db/database/sourcedata/AD_MESSAGE.xml | 14 +++++++++++++-
2 files changed, 15 insertions(+), 3 deletions(-)
diffs (45 lines):
diff -r 97fe6cfd4944 -r 74a3926b798b
src-db/database/model/functions/M_MOVEMENT_POST.xml
--- a/src-db/database/model/functions/M_MOVEMENT_POST.xml Fri Nov 25
11:27:36 2016 +0100
+++ b/src-db/database/model/functions/M_MOVEMENT_POST.xml Mon Nov 21
10:41:15 2016 -0800
@@ -190,8 +190,8 @@
LOOP
v_ResultStr:='Transaction for line' || Cur_MoveLine.Line;
- IF (Cur_MoveLine.MovementQty = 0) THEN
- RAISE_APPLICATION_ERROR(-20000,'@GoodsMovementsWithZeroQty@' || '
@Inline@ ' || Cur_MoveLine.line) ;
+ IF (Cur_MoveLine.MovementQty <= 0) THEN
+ RAISE_APPLICATION_ERROR(-20000,'@GoodsMovementsWithNegativeQty@'
|| ' @Inline@ ' || Cur_MoveLine.line) ;
END IF;
IF (cur_moveline.m_reservation_id IS NOT NULL) THEN
diff -r 97fe6cfd4944 -r 74a3926b798b src-db/database/sourcedata/AD_MESSAGE.xml
--- a/src-db/database/sourcedata/AD_MESSAGE.xml Fri Nov 25 11:27:36 2016 +0100
+++ b/src-db/database/sourcedata/AD_MESSAGE.xml Mon Nov 21 10:41:15 2016 -0800
@@ -17203,7 +17203,7 @@
<!--1E33F2F8858B48D79F845F72CD828861--> <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
<!--1E33F2F8858B48D79F845F72CD828861--> <ISACTIVE><![CDATA[Y]]></ISACTIVE>
<!--1E33F2F8858B48D79F845F72CD828861-->
<VALUE><![CDATA[GoodsMovementsWithZeroQty]]></VALUE>
-<!--1E33F2F8858B48D79F845F72CD828861--> <MSGTEXT><![CDATA[Is is not possible
to process because one line has value zero in movement quantity. Please insert
a different value from zero.]]></MSGTEXT>
+<!--1E33F2F8858B48D79F845F72CD828861--> <MSGTEXT><![CDATA[It is not possible
to process because one line has value zero in movement quantity. Please insert
a different value from zero.]]></MSGTEXT>
<!--1E33F2F8858B48D79F845F72CD828861--> <MSGTYPE><![CDATA[E]]></MSGTYPE>
<!--1E33F2F8858B48D79F845F72CD828861-->
<AD_MODULE_ID><![CDATA[0]]></AD_MODULE_ID>
<!--1E33F2F8858B48D79F845F72CD828861-->
<ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N>
@@ -21408,6 +21408,18 @@
<!--74560B0C1A2C42DABDEFE33B6AEB3B86-->
<ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N>
<!--74560B0C1A2C42DABDEFE33B6AEB3B86--></AD_MESSAGE>
+<!--747C2388755148C68AA90B056CC47255--><AD_MESSAGE>
+<!--747C2388755148C68AA90B056CC47255-->
<AD_MESSAGE_ID><![CDATA[747C2388755148C68AA90B056CC47255]]></AD_MESSAGE_ID>
+<!--747C2388755148C68AA90B056CC47255-->
<AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
+<!--747C2388755148C68AA90B056CC47255--> <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
+<!--747C2388755148C68AA90B056CC47255--> <ISACTIVE><![CDATA[Y]]></ISACTIVE>
+<!--747C2388755148C68AA90B056CC47255-->
<VALUE><![CDATA[GoodsMovementsWithNegativeQty]]></VALUE>
+<!--747C2388755148C68AA90B056CC47255--> <MSGTEXT><![CDATA[It is not possible
to process because one line has zero or negative value in movement quantity.
Please insert a positive value.]]></MSGTEXT>
+<!--747C2388755148C68AA90B056CC47255--> <MSGTYPE><![CDATA[E]]></MSGTYPE>
+<!--747C2388755148C68AA90B056CC47255-->
<AD_MODULE_ID><![CDATA[0]]></AD_MODULE_ID>
+<!--747C2388755148C68AA90B056CC47255-->
<ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N>
+<!--747C2388755148C68AA90B056CC47255--></AD_MESSAGE>
+
<!--7483DF96F3C34BB38C67B66BFAC79404--><AD_MESSAGE>
<!--7483DF96F3C34BB38C67B66BFAC79404-->
<AD_MESSAGE_ID><![CDATA[7483DF96F3C34BB38C67B66BFAC79404]]></AD_MESSAGE_ID>
<!--7483DF96F3C34BB38C67B66BFAC79404-->
<AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
------------------------------------------------------------------------------
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
