details: https://code.openbravo.com/erp/devel/pi/rev/0d4102902eea changeset: 31560:0d4102902eea user: Asier Lostalé <asier.lostale <at> openbravo.com> date: Fri Feb 24 13:07:53 2017 +0100 summary: fixed bug 35346: can't save grid record with multi field pick list selector
Records in tabs with a column having a selector with multiple fields in pick list couldn't be saved in grid after opening form view. The problem was casued becasue this kind of selectors require to calculate the size for the picking list, but when saving it is already closed so it failed assuming it has a grid. Fixed by checking if grid is present which indirectly checks if it is visible. details: https://code.openbravo.com/erp/devel/pi/rev/08e1c23f74a1 changeset: 31561:08e1c23f74a1 user: Asier Lostalé <asier.lostale <at> openbravo.com> date: Fri Feb 24 13:15:05 2017 +0100 summary: related to bug 31674: apply proper java formatting details: https://code.openbravo.com/erp/devel/pi/rev/a393f7e134d6 changeset: 31562:a393f7e134d6 user: Asier Lostalé <asier.lostale <at> openbravo.com> date: Fri Feb 24 13:26:11 2017 +0100 summary: fixed issue 31674: don't show stack trace in log on failed login Removed log with error level for invalid logins. It was already logged with debug level which is enough. diffstat: modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js | 4 +- src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java | 13 +++++---- 2 files changed, 9 insertions(+), 8 deletions(-) diffs (64 lines): diff -r ad4f5d64125d -r a393f7e134d6 modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js --- a/modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js Fri Feb 24 11:52:40 2017 +0100 +++ b/modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js Fri Feb 24 13:26:11 2017 +0100 @@ -11,7 +11,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU - * All portions are Copyright (C) 2011-2016 Openbravo SLU + * All portions are Copyright (C) 2011-2017 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************ @@ -699,7 +699,7 @@ // Dropdown selector that shows more than one column. if (this.pickListFields.length > 1) { // calculate width of checkBox and first fields before selector field in viewGrid - if (this.form.view && !this.form.view.isShowingForm) { + if (this.form.view && !this.form.view.isShowingForm && this.grid) { while (i < this.grid.fields.size() && nameField.localeCompare(this.grid.fields.get(i).valueField) !== 0) { leftFieldsWidth = leftFieldsWidth + this.grid.fields.get(i).width; i++; diff -r ad4f5d64125d -r a393f7e134d6 src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java --- a/src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java Fri Feb 24 11:52:40 2017 +0100 +++ b/src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java Fri Feb 24 13:26:11 2017 +0100 @@ -99,8 +99,8 @@ // user and password come after BASIC final String userpassEncoded = auth.substring(6); // Decode it, using any base 64 decoder - final String decodedUserPass = new String( - Base64.decodeBase64(userpassEncoded.getBytes())); + final String decodedUserPass = new String(Base64.decodeBase64(userpassEncoded + .getBytes())); final int index = decodedUserPass.indexOf(":"); if (index != -1) { user = decodedUserPass.substring(0, index); @@ -144,7 +144,7 @@ errorMsg.setMessage("LOCKED_USER_MSG"); } - throw new AuthenticationException("IDENTIFICATION_FAILURE_TITLE", errorMsg); + throw new AuthenticationException("IDENTIFICATION_FAILURE_TITLE", errorMsg, false); } vars.setSessionValue("#AD_User_ID", userId); @@ -198,15 +198,16 @@ } /** - * Checks the expiration password date from userId, throws AuthenticationExpirationPasswordException in case that expiration - * date is reached + * Checks the expiration password date from userId, throws + * AuthenticationExpirationPasswordException in case that expiration date is reached * * @param userId * The userId of the user to check expiration password date * @param language * Default language for the user * @throws AuthenticationExpirationPasswordException - * AuthenticationExpirationPasswordException is thrown in case that expiration date is reached + * AuthenticationExpirationPasswordException is thrown in case that expiration date is + * reached * */ private void checkIfPasswordExpired(String userId, String language) ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Openbravo-commits mailing list Openbravo-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-commits
