details:   https://code.openbravo.com/erp/devel/pi/rev/6e589a875d4b
changeset: 31727:6e589a875d4b
user:      Mark <markmm82 <at> gmail.com>
date:      Wed Mar 22 13:31:58 2017 -0400
summary:   Related to issue 31534: Code review improvements

Replaced use of StringUtils.equals(strcAcctSchemaId, "") with 
StringUtils.isEmpty
function

details:   https://code.openbravo.com/erp/devel/pi/rev/bf2f97e60aa6
changeset: 31728:bf2f97e60aa6
user:      Mark <markmm82 <at> gmail.com>
date:      Wed Mar 22 13:37:20 2017 -0400
summary:   Related to issue 31529: Code review improvements

Replaced use of StringUtils.equals(strcAcctSchemaId, "") with 
StringUtils.isEmpty
function

diffstat:

 src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger.java        |  2 +-
 src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java |  2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diffs (24 lines):

diff -r e486ba4ac971 -r bf2f97e60aa6 
src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger.java
--- a/src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger.java   Wed Mar 
22 17:41:41 2017 +0000
+++ b/src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger.java   Wed Mar 
22 13:37:20 2017 -0400
@@ -63,7 +63,7 @@
     if (vars.commandIn("DEFAULT")) {
       String strOrg = vars.getGlobalVariable("inpOrg", 
"ReportGeneralLedger|Org", vars.getOrg());
       String strcAcctSchemaId = 
vars.getSessionValue("ReportGeneralLedger|cAcctSchemaId");
-      if (StringUtils.equals(strcAcctSchemaId, "")) {
+      if (StringUtils.isEmpty(strcAcctSchemaId)) {
         strcAcctSchemaId = OBLedgerUtils.getOrgLedger(strOrg);
       }
       String strDateFrom = vars
diff -r e486ba4ac971 -r bf2f97e60aa6 
src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
--- a/src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java    
Wed Mar 22 17:41:41 2017 +0000
+++ b/src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java    
Wed Mar 22 13:37:20 2017 -0400
@@ -94,7 +94,7 @@
       String strOrg = vars.getGlobalVariable("inpOrg", 
"ReportGeneralLedgerJournal|Org",
           vars.getOrg());
       String strcAcctSchemaId = 
vars.getSessionValue("ReportGeneralLedgerJournal|cAcctSchemaId");
-      if (StringUtils.equals(strcAcctSchemaId, "")) {
+      if (StringUtils.isEmpty(strcAcctSchemaId)) {
         strcAcctSchemaId = OBLedgerUtils.getOrgLedger(strOrg);
       }
       String strDateFrom = vars.getGlobalVariable("inpDateFrom",

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to