details:   https://code.openbravo.com/erp/devel/pi/rev/302d949e828a
changeset: 32243:302d949e828a
user:      Miguel de Juana <miguel.dejuana <at> openbravo.com>
date:      Tue May 30 17:12:16 2017 +0200
summary:   Fixed issue 0036037: PostImportEntry hook is getting executed even 
if the record goes to Errors While Importing window

- Move hooks to MobileImportEntryProcessorRunnable and execute them just when 
success

diffstat:

 src/org/openbravo/service/importprocess/ImportEntryPostProcessor.java |   2 +-
 src/org/openbravo/service/importprocess/ImportEntryProcessor.java     |  13 
----------
 2 files changed, 1 insertions(+), 14 deletions(-)

diffs (56 lines):

diff -r d04a20929288 -r 302d949e828a 
src/org/openbravo/service/importprocess/ImportEntryPostProcessor.java
--- a/src/org/openbravo/service/importprocess/ImportEntryPostProcessor.java     
Tue May 30 18:59:43 2017 +0000
+++ b/src/org/openbravo/service/importprocess/ImportEntryPostProcessor.java     
Tue May 30 17:12:16 2017 +0200
@@ -11,7 +11,7 @@
  * under the License. 
  * The Original Code is Openbravo ERP. 
  * The Initial Developer of the Original Code is Openbravo SLU 
- * All portions are Copyright (C) 2015 Openbravo SLU
+ * All portions are Copyright (C) 2015-2017 Openbravo SLU
  * All Rights Reserved.
  * Contributor(s):  ______________________________________.
  ************************************************************************
diff -r d04a20929288 -r 302d949e828a 
src/org/openbravo/service/importprocess/ImportEntryProcessor.java
--- a/src/org/openbravo/service/importprocess/ImportEntryProcessor.java Tue May 
30 18:59:43 2017 +0000
+++ b/src/org/openbravo/service/importprocess/ImportEntryProcessor.java Tue May 
30 17:12:16 2017 +0200
@@ -29,8 +29,6 @@
 import java.util.concurrent.ExecutorService;
 
 import javax.enterprise.context.ApplicationScoped;
-import javax.enterprise.inject.Any;
-import javax.enterprise.inject.Instance;
 import javax.inject.Inject;
 
 import org.apache.log4j.Logger;
@@ -42,7 +40,6 @@
 import org.openbravo.dal.service.OBDal;
 import org.openbravo.database.SessionInfo;
 import org.openbravo.model.common.enterprise.Organization;
-import 
org.openbravo.service.importprocess.ImportEntryManager.ImportEntryProcessorSelector;
 
 /**
  * The {@link ImportEntryProcessor} is responsible for importing/processing 
{@link ImportEntry}
@@ -273,10 +270,6 @@
     // when the garbagecollector runs
     private Map<String, OBContext> cachedOBContexts = new HashMap<String, 
OBContext>();
 
-    @Inject
-    @Any
-    private Instance<ImportEntryPostProcessor> importEntryPostProcessors;
-
     public ImportEntryProcessRunnable() {
       logger = Logger.getLogger(this.getClass());
     }
@@ -369,12 +362,6 @@
 
           processEntry(localImportEntry);
 
-          // Execute post process hooks.
-          for (ImportEntryPostProcessor importEntryPostProcessor : 
importEntryPostProcessors
-              .select(new ImportEntryProcessorSelector(typeOfData))) {
-            importEntryPostProcessor.afterProcessing(localImportEntry);
-          }
-
           if (logger.isDebugEnabled()) {
             logger.debug("Finished Processing entry " + 
localImportEntry.getIdentifier() + " "
                 + typeOfData);

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to