details: https://code.openbravo.com/erp/devel/pi/rev/198240535488
changeset: 32279:198240535488
user: Asier Lostalé <asier.lostale <at> openbravo.com>
date: Thu Jun 08 15:03:10 2017 +0200
summary: fixed bug 36193: fetch for P&E logs error if obSelected property
does not exist
Even exception was logged it was not thrown up, correctly returning false.
This
event shouldn't be logged at all.
diffstat:
modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
| 12 ++++++---
1 files changed, 8 insertions(+), 4 deletions(-)
diffs (29 lines):
diff -r e1cdf33211c8 -r 198240535488
modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
---
a/modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
Thu Jun 08 13:50:16 2017 +0200
+++
b/modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
Thu Jun 08 15:03:10 2017 +0200
@@ -373,17 +373,21 @@
}
private boolean isLastRecordSelected(List<BaseOBObject> bobs) {
- if (bobs.size() == 0) {
+ if (bobs.isEmpty()) {
return false;
}
- Boolean b = Boolean.FALSE;
+
try {
BaseOBObject bob = bobs.get(bobs.size() - 1);
- b = (Boolean) bob.get("obSelected");
+
+ if (!bob.getEntity().hasProperty("obSelected")) {
+ return false;
+ }
+ return (Boolean) bob.get("obSelected");
} catch (Exception ex) {
// Error retrieving obSelected property, do nothing: record not selected
+ return false;
}
- return b.booleanValue();
}
public void fetch(Map<String, String> parameters, QueryResultWriter writer) {
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
