details: https://code.openbravo.com/erp/devel/pi/rev/e0985a011081
changeset: 32354:e0985a011081
user: Carlos Aristu <carlos.aristu <at> openbravo.com>
date: Fri Jun 23 15:17:16 2017 +0200
summary: fixes bug 36320: Create Lines P&E grid gets freezed under some
circumstances
When moving to a record in a P&E leaving the current record without filling
all the mandatory fields, the P&E got freezed due to an infinite loop.
This was caused due to the changes introduced with the fix for the issue
#34824, which prevents to leave the current record if not all the mandatory
fields are filled. Being in a P&E grid which does not allow inserts, that
change causes an infinite loop in Smartclient. Thi is because the
hideInlineEditor flow is never completed, which makes the cellEditMethod being
called continuolsy.
As the change for issue #34824 was intended for P&E grids in which records
can be added, this change ensures that the default action executed in
hideInlineEditor are cancelled just for that kind of grids. This allows to keep
the behavior fixed on issue #34824 and fixes the problem for the rest of the
P&E grids.
diffstat:
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
| 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diffs (12 lines):
diff -r e0868e17dc99 -r e0985a011081
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
Fri Jun 23 11:51:54 2017 +0000
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
Fri Jun 23 15:17:16 2017 +0200
@@ -1008,7 +1008,7 @@
hideInlineEditor: function (focusInBody, suppressCMHide) {
var ret;
- if (this.isRequiredFieldWithNoValue()) {
+ if (this.viewProperties && this.viewProperties.allowAdd &&
this.isRequiredFieldWithNoValue()) {
return;
} else {
ret = this.Super('hideInlineEditor', arguments);
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
