details: https://code.openbravo.com/erp/devel/main/rev/4f8b6743e711 changeset: 32425:4f8b6743e711 user: Armaignac <collazoandy4 <at> gmail.com> date: Fri Jun 23 10:40:44 2017 -0400 summary: Fixes issue 36386: Wrong schedule details when voiding a prepaid invoice
The void process of prepaid invoice was taking into account all payments schedule detail to update their amount with the invoice payment schedule amount. Now the order payment schedule detail update it it's the one not asociated to any invoice or a new one is created if the order have no pending payment schedule detail. The invoice prepayment amount was also incorrect when the invoice is created from CreateInvoicesFromOrder process and the order have a discount line. Now the compute of prepayment amount is made without join the order lines to prevent duplicate the payment schedule paidamt. details: https://code.openbravo.com/erp/devel/main/rev/cd7822ad1e55 changeset: 32426:cd7822ad1e55 user: Armaignac <collazoandy4 <at> gmail.com> date: Mon Jul 10 12:49:45 2017 +0200 summary: Fixes issue 36397: Avoid casting when adding numeric results in SimpleCallout The casting to Object was replace by a integer conversion, sending the corresponding numeric value when it applies. details: https://code.openbravo.com/erp/devel/main/rev/e925840e8cc2 changeset: 32427:e925840e8cc2 user: Armaignac <collazoandy4 <at> gmail.com> date: Mon Jul 10 15:08:05 2017 -0400 summary: Related to issue 36397: Hide secondUOM fields if product doesn't have secondUOM When a product with a second UOM was selected the associated fields are shown, but not hidden when the product is change and doesn't have a second UOM because the has_second_uom var is not updated with the corresponding value according to the product selection. The value of has_second_uom var is updated according to the product selection in the result for a correct use in display logic function. details: https://code.openbravo.com/erp/devel/main/rev/6bbdc902b86c changeset: 32428:6bbdc902b86c user: Asier Lostalé <asier.lostale <at> openbravo.com> date: Tue Jul 11 09:13:34 2017 +0200 summary: fixed bug 36460: in grid can trigger save before FIC response is received While editing in grid mode, it is possible to trigger save action by clicking grid's save button while FIC response is not received yet. If this occurs, the data sent to backend misses information that FIC should update. If grid's save button is clicked while in FIC call, postpone save action till FIC return. details: https://code.openbravo.com/erp/devel/main/rev/589094b8635e changeset: 32429:589094b8635e user: Asier Lostalé <asier.lostale <at> openbravo.com> date: Tue Jul 11 13:29:02 2017 +0200 summary: fixed 36469: inconsistent grid state if cancelling changes before FIC response If while editing in grid mode, changes are cancelled before receiving FIC response, it was possible to: - Create a new partial and incorrect line with only the data returned from FIC in case no line was being edited - Apply changes from FIC to incorrect row if another one was being edited Both problems are fixed by applying FIC changes only if the record is the same the request was triggered for, this is checked by ensuring both row number and record id. If editin a different record, FIC response is simply ignored. details: https://code.openbravo.com/erp/devel/main/rev/7cda6130ff93 changeset: 32430:7cda6130ff93 user: Armaignac <collazoandy4 <at> gmail.com> date: Tue Jul 18 11:06:02 2017 -0400 summary: Fixes issue 36482: Cannot add some sales order lines to goods shipments after upgrading to 3.0PR17Q1 as a modulescript set the order as isdelivered Cannot add some sales order lines to goods shipments because the modulescript set the order as isdelivered when the order contains lines with negative qtyordered and the sum(qtyordered) = sum(qtydelivered) Now the update only happend when the order don't have a line where QTYORDERED <> QTYDELIVERED. Because the NOT EXISTS change the check to issotrx field now is made in the main query because a wrong evaluation in the subquery happends when issotrx = 'N' and NOT EXISTS details: https://code.openbravo.com/erp/devel/main/rev/fb946104af61 changeset: 32431:fb946104af61 user: Asier Lostalé <asier.lostale <at> openbravo.com> date: Wed Aug 02 10:30:22 2017 +0200 summary: fixed bug 36574: import sample data can get stuck if executed concurrently It was caused by a concurrent modification/read of cache HashMap in DynaClassCache. As getDynaClass is the only method that reads and modifies this internal cache, the fix is to make it synchronized. Checked also, while importing sample data this is the only place where shared objects are modified. details: https://code.openbravo.com/erp/devel/main/rev/5f841c72ce1b changeset: 32432:5f841c72ce1b user: Mark <markmm82 <at> gmail.com> date: Mon Aug 21 15:43:39 2017 -0400 summary: Fixes issue 36667: Wrong quantity in inventory lines * Send quantities as BigDecimal instead of String. * Remove unnecessary displaylogic() execute. details: https://code.openbravo.com/erp/devel/main/rev/bbbad6d27d8b changeset: 32433:bbbad6d27d8b user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> date: Wed Aug 23 11:01:23 2017 +0200 summary: Related to issue 36667: Update copyright details: https://code.openbravo.com/erp/devel/main/rev/06c655f757ea changeset: 32434:06c655f757ea user: Carlos Aristu <carlos.aristu <at> openbravo.com> date: Tue Aug 29 13:25:09 2017 +0200 summary: fixes bug 36737: Can't use fields based on some properties in selector picklist With the fix for issue #36268 the selector fields based on derived properties that are shown in the picklist are sent as 'extra properties' in order to calculate them properly. The problem is that the fix was not complete when the derived properties were not primitive. In that case the DataToJsonConverter class was not calculating properly the referenced property. Now that kind of properties are calculated properly. details: https://code.openbravo.com/erp/devel/main/rev/87bb93f75b52 changeset: 32435:87bb93f75b52 user: Mark <markmm82 <at> gmail.com> date: Wed Aug 23 14:16:09 2017 -0400 summary: Fixes issue 36692: Transaction Cost not created for closing inventory lines After cost was assigned to closing inventory lines transactions, when calling to insertTrxCosts() from calculateCosts() method (second call), CostingUtilsData.countTrxCosts(conn) was getting 0 in countTrx. It was caused because closing inventory lines cost calculation was done by OBDal connection, and methods invoked in CostingUtilsData are done using different connection provided by SQLC, and the transactions are not available at this moment. See: http://wiki.openbravo.com/wiki/Data_Access_Layer#Transaction_and_Session To find the best solution for this issue and don't affect the performance (see issue 35959), different solutions were tested to always use DAL and make process use the same connection. 1.- Doing a single insert-select query with limits is not supported in DAL. We tried it in two different ways (see attached TestCosting_v1.diff): - Use setMaxResults(). It only works for selects but not for inserts/updates. - Use setMaxResults() in select query and append it to insert query using getQueryString(). It appends the select without any limit. 2.- Another option could be to refactor insertTrxCosts() method to do a multiple insert query: We can create the select query with limits using setMaxResults(), iterate it using an scroll and create and save in each iteration a new TransactionCost. Flush won't be done in every iteration. When flush is done, it raises every insert in multiple single-row inserts instead of only one multiple-row insert. Single-row inserts performs worst than multiple-row insert, at least with not many rows (see attached TestCosting_v2.diff). 3.- Finally, we have refactor the process to avoid insertTrxCosts() method: Our solution makes an insertion in M_Transaction_Cost table each time we make the updation of related transaction cost in M_Transaction table. We will do single-row inserts in two methods: updateTrxLegacyCosts() and calculateCosts(), and multiple-row insert in one method: updateWithZeroCostRemainingTrx(). Thus, we split the number of TransactionCost records to be created in three different steps. details: https://code.openbravo.com/erp/devel/main/rev/fbbdcccd3272 changeset: 32436:fbbdcccd3272 user: Carlos Aristu <carlos.aristu <at> openbravo.com> date: Mon Sep 04 09:23:10 2017 +0200 summary: fixes bug 36765: Audit info not updated when replacing an already attached file The audit information (updated, updated by fields) of the attachments was not being updated after replacing an already attached file. In this case the OBInterceptor was not being invoked because the information of the attachment (BaseOBObject) was indeed not changing. To fix this problem we explicitly change the 'updated' date of the attachment and the OBInterceptor will take care of update the rest of the audit information (updated by). details: https://code.openbravo.com/erp/devel/main/rev/32cdec7e132d changeset: 32437:32cdec7e132d user: Mark <markmm82 <at> gmail.com> date: Mon Sep 04 12:44:00 2017 -0400 summary: Fixes issue 36793: Amounts in invoice lines and taxes rounded to price precision instead of standard precision in Create Lines From process. In CreateFrom class, the price precision was used for rounding amounts instead of standard precision and it was causing differences with totals when invoices were created from orders or shipments. Now all prices are rounded with the price precision of it currency and amounts with standard precision. details: https://code.openbravo.com/erp/devel/main/rev/bd2c37a633fc changeset: 32438:bd2c37a633fc user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> date: Tue Sep 05 12:37:04 2017 +0200 summary: Related to issue 36793: Code review improvements Retrieve currency standard precision instead of price precision in selectFromPO, selectFromPOUpdate, selectFromPOUpdateSOTrx and selectPriceList methods. Do not round price actual with price precision when calculating line net amount. Remove unused priceprecision variable. Use data variable to retrieve currency standard precision when creating invoice from order and dataAux variable when creating invoice from receipt/shipment. details: https://code.openbravo.com/erp/devel/main/rev/5cf3ad9801ae changeset: 32439:5cf3ad9801ae user: David Miguelez <david.miguelez <at> openbravo.com> date: Tue Sep 05 18:46:27 2017 +0200 summary: Fixes Issue 36798. Check that the Inventory Status of the Bin has the Available flag checked for Goods Shipments and Return To Vendor Shipments (outgoing warehouse transactions in the M_INOUT_POST) details: https://code.openbravo.com/erp/devel/main/rev/fd71055b3e97 changeset: 32440:fd71055b3e97 user: Carlos Aristu <carlos.aristu <at> openbravo.com> date: Mon Sep 11 12:05:17 2017 +0200 summary: related to bug 36765: Update attachment last update when metadata also changes details: https://code.openbravo.com/erp/devel/main/rev/38763191a196 changeset: 32441:38763191a196 user: David Miguelez <david.miguelez <at> openbravo.com> date: Fri Sep 08 12:30:00 2017 +0200 summary: Fixes Issue 36823. Changed API * Added new boolean parameter to funciton * Created two new functions to call the original one without the boolean parameter * Changed save by a flush to avoid problems when the Hibernate session is cleared details: https://code.openbravo.com/erp/devel/main/rev/d18f353e75f2 changeset: 32442:d18f353e75f2 user: David Miguelez <david.miguelez <at> openbravo.com> date: Mon Sep 11 13:05:23 2017 +0200 summary: Related to issue 36823. Changed visibility of method to private since it should be called from getNumberOfTotalVirutalBins and getNumberOfActiveVirtualBins public methods instead. details: https://code.openbravo.com/erp/devel/main/rev/5a80fe33e7c1 changeset: 32443:5a80fe33e7c1 user: Carlos Aristu <carlos.aristu <at> openbravo.com> date: Tue Sep 12 15:50:45 2017 +0200 summary: related to bug 36765: last update not updated when removing description The last updated information is now updated when the description of an existing attachment is cleared. This was not happening before, because the record in the OBUIAPP_Parameter_Value table was removed when the value to be assigned is null details: https://code.openbravo.com/erp/devel/main/rev/415490026f05 changeset: 32444:415490026f05 user: Carlos Aristu <carlos.aristu <at> openbravo.com> date: Wed Sep 13 10:24:26 2017 +0200 summary: fixes issue 36842: js defaults containing Dates fail in JRE8 In Java 8 JavaScript engine was changed from Rhino to Nashorn. JavaScript Dates evaluated in server, returned a java.util.Date in Rhino, but with Nashorn they are evaluated to jdk.nashorn.internal.objects.NativeDate. This change caused a ClassCastException in JRE8 when invoking the methods of OBBindings which receive a java.util.Date as an argument. To fix the problem those methods have been overloaded by receiving an Object as argument. Therefore these methods will be invoked when working with JRE8, and we use reflection to retrieve the time information avoiding using classes which are not supported in JRE7. details: https://code.openbravo.com/erp/devel/main/rev/a8925ad2d61f changeset: 32445:a8925ad2d61f user: RM packaging bot <staff.rm <at> openbravo.com> date: Mon Sep 18 04:52:09 2017 +0000 summary: Update AD_MODULE version to 3.0PR17Q3 details: https://code.openbravo.com/erp/devel/main/rev/ff7be0e0ba87 changeset: 32446:ff7be0e0ba87 user: RM packaging bot <staff.rm <at> openbravo.com> date: Mon Sep 18 04:52:09 2017 +0000 summary: Added tag 3.0PR17Q3 for changeset a8925ad2d61f details: https://code.openbravo.com/erp/devel/main/rev/be1b68bf422e changeset: 32447:be1b68bf422e user: RM packaging bot <staff.rm <at> openbravo.com> date: Mon Sep 18 04:52:09 2017 +0000 summary: Added signature for changeset ff7be0e0ba87 details: https://code.openbravo.com/erp/devel/main/rev/1509bbd77a82 changeset: 32448:1509bbd77a82 user: RM packaging bot <staff.rm <at> openbravo.com> date: Thu Sep 21 04:04:59 2017 +0000 summary: Merge temporary head for 3.0PR17Q3 diffstat: .hgsigs | 5 +++++ .hgtags | 5 +++++ 2 files changed, 10 insertions(+), 0 deletions(-) diffs (26 lines): diff -r afd14b274336 -r 1509bbd77a82 .hgsigs --- a/.hgsigs Fri Jun 30 15:05:29 2017 +0000 +++ b/.hgsigs Thu Sep 21 04:04:59 2017 +0000 @@ -213,4 +213,9 @@ 3a7510a5ee0b43ac0a65e4eae9b089f42158bbe0 0 iEYEABECAAYFAljGfFgACgkQCX/oGf+2qkOgoQCgx3u3UhiV8NyyiBZLsFjlwicCp1EAoPAl4mZZ6/wURPq39Ef6Rtbe1BRb 835355e0fdbd35df49b4b559a4ce984192350fd2 0 iEYEABECAAYFAlkVX0kACgkQCX/oGf+2qkMVEQCfasQyxkrJdtvkEP03xKFyiwAi2f0AnRRguCtQ0qKkra8Kg55F7/9oKS7p 1ec47090dc22cda681ebf04a2ea7491b971bb24d 0 iEYEABECAAYFAllLmP4ACgkQCX/oGf+2qkMZvgCggmmfbWJEY/hgJWXzwmfsSEHcEzkAoMGb1VsoDMaU/TIjFRvnCRXoj7Eh +58658da4e8fc26f50c49846910da9c4ff7afd417 0 iEYEABECAAYFAlmJYmkACgkQCX/oGf+2qkNQ2ACbBnQYMdCROIRP7KW2tYz46AeqPNgAn07znI+o6t4KIJPBnqy61/mf6hEc 74c2ec78cab6580e2c5fd67e4c7913924339df58 0 iEYEABECAAYFAlkdU7MACgkQCX/oGf+2qkMs3wCguelDCm09norUvWOnB7m/+X66yyMAoKr/DzyFXmSZTrlta3cfBpn5BY6v +0e959ce9b986f2770ac4ac02296a59adaafdc919 0 iEYEABECAAYFAllSJLwACgkQCX/oGf+2qkOkKACfWiWW37hMTW9d4fneU+4JJsG//LYAoLkOPDVyEZCTY/IpOEuXT0hHKE9e +4bad64e9d7577310506e2e19cacba696ed703ad6 0 iEYEABECAAYFAlmKpMUACgkQCX/oGf+2qkNGywCgobMSxQWqAp5l5HsKqlQMPn8GkNsAoOBNizvazzb9wRiYA1/57ntgR253 +9e6056c0e38e4355acf8d72a8efab6575c7f9733 0 iEYEABECAAYFAlm40qMACgkQCX/oGf+2qkPKxgCgndqN2CnOSnbnZEsQntY+mUaqZZEAoK6Xl9Q4HbgHep6JG/owLOzyehRK +ff7be0e0ba8762069ad86523828a57139b396d39 0 iEYEABECAAYFAlm/UPkACgkQCX/oGf+2qkM8UQCdGDxGviT6mh8nKnu2HP1qzZzX0cYAoJaBd9WSUNj2Dlh2yjJT+7zYxKcC diff -r afd14b274336 -r 1509bbd77a82 .hgtags --- a/.hgtags Fri Jun 30 15:05:29 2017 +0000 +++ b/.hgtags Thu Sep 21 04:04:59 2017 +0000 @@ -224,4 +224,9 @@ 273c24deef8f21e870cf563073cc653582a9fe9e 3.0PR17Q1 10c0ffee4e6ccca6771d151dd27f706e50cf4b96 3.0PR17Q1.1 a2e2a8540b6e64102d4e019efc36ad05c7f43b24 3.0PR17Q1.2 +07a679139b1b9f7544e3d0954fd77b3a2aa8ed04 3.0PR17Q1.3 7fd66b51c666e341168a7e5a036f7ac25a86eec9 3.0PR17Q2 +c37991aee21566d0ed397369377abdaeaf1a6f52 3.0PR17Q2.1 +632ba9b2ee8c8133be5b483482d3d99a83b4138f 3.0PR17Q2.2 +7fafd2a9f24bd0d5889253005412101631cc1efe 3.0PR17Q2.3 +a8925ad2d61f4625aa62c1ee31babecaa73b787f 3.0PR17Q3 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openbravo-commits mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openbravo-commits
