details: https://code.openbravo.com/erp/devel/pi/rev/e93ad7f316fc
changeset: 33001:e93ad7f316fc
user: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
date: Tue Nov 14 14:13:19 2017 +0100
summary: Related with issue 37278: Added test case
diffstat:
src-test/src/org/openbravo/test/AllAntTaskTests.java | 4
+-
src-test/src/org/openbravo/test/security/RoleListForTheCurrentUser.java | 137
++++++++++
2 files changed, 140 insertions(+), 1 deletions(-)
diffs (163 lines):
diff -r 01c6dc6168f6 -r e93ad7f316fc
src-test/src/org/openbravo/test/AllAntTaskTests.java
--- a/src-test/src/org/openbravo/test/AllAntTaskTests.java Mon Nov 06
17:31:38 2017 -0500
+++ b/src-test/src/org/openbravo/test/AllAntTaskTests.java Tue Nov 14
14:13:19 2017 +0100
@@ -93,6 +93,7 @@
import org.openbravo.test.security.CrossOrganizationUICDI;
import org.openbravo.test.security.EntityAccessTest;
import org.openbravo.test.security.OBContextCollectionsTest;
+import org.openbravo.test.security.RoleListForTheCurrentUser;
import org.openbravo.test.security.StandardCrossOrganizationReference;
import org.openbravo.test.security.WritableReadableOrganizationClientTest;
import org.openbravo.test.services.ServicesTest;
@@ -182,7 +183,8 @@
BypassAccessLevelCheck.class, //
CrossOrganizationUI.class, //
CrossOrganizationUICDI.class, //
- OBContextCollectionsTest.class,
+ OBContextCollectionsTest.class, //
+ RoleListForTheCurrentUser.class,
// system
SystemServiceTest.class, //
diff -r 01c6dc6168f6 -r e93ad7f316fc
src-test/src/org/openbravo/test/security/RoleListForTheCurrentUser.java
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/src-test/src/org/openbravo/test/security/RoleListForTheCurrentUser.java
Tue Nov 14 14:13:19 2017 +0100
@@ -0,0 +1,137 @@
+/*
+ *************************************************************************
+ * The contents of this file are subject to the Openbravo Public License
+ * Version 1.1 (the "License"), being the Mozilla Public License
+ * Version 1.1 with a permitted attribution clause; you may not use this
+ * file except in compliance with the License. You may obtain a copy of
+ * the License at http://www.openbravo.com/legal/license.html
+ * Software distributed under the License is distributed on an "AS IS"
+ * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See the
+ * License for the specific language governing rights and limitations
+ * under the License.
+ * The Original Code is Openbravo ERP.
+ * The Initial Developer of the Original Code is Openbravo SLU
+ * All portions are Copyright (C) 2017 Openbravo SLU
+ * All Rights Reserved.
+ * Contributor(s): ______________________________________.
+ ************************************************************************
+ */
+package org.openbravo.test.security;
+
+import static org.hamcrest.Matchers.equalTo;
+import static org.junit.Assert.assertThat;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.codehaus.jettison.json.JSONArray;
+import org.codehaus.jettison.json.JSONException;
+import org.codehaus.jettison.json.JSONObject;
+import org.junit.Test;
+import org.openbravo.dal.core.OBContext;
+import org.openbravo.dal.service.OBDal;
+import org.openbravo.model.ad.access.UserRoles;
+import org.openbravo.test.datasource.BaseDataSourceTestDal;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * This test ensures that a deactivated role in the User Roles subtab is not
appeared in the User
+ * profile widget. The problem was introduced with the performance
improvements applied on the login
+ * process.
+ *
+ * See regression: https://issues.openbravo.com/view.php?id=37278
+ *
+ * @author inigo.sanchez
+ */
+
+public class RoleListForTheCurrentUser extends BaseDataSourceTestDal {
+ private static Logger log =
LoggerFactory.getLogger(RoleListForTheCurrentUser.class);
+
+ private static final String STR_START = ",role:{value";
+ private static final String STR_FINISH = "],roles";
+
+ // Role: F&B US, Inc. - Employee
+ private static final String TESTED_ROLE_ID =
"19AE26382A674FE8946D2B8070D10122";
+ // User Role: Openbravo User - F&B US, Inc. - Employee Role
+ private static final String USER_ROLE_TEST =
"3B960D8A87CA4F77907DF2B7F9A77366";
+ private static final int EXPECTED_ROLES = 13;
+
+ @Test
+ public void isShownDeactivateRoleInUserProfileWidget() throws Exception {
+ try {
+ String response = doLoginRequest();
+ JSONArray rolesInUserProfileWidget = transformResponse(response);
+ assertThat("The activated role is not present in the dropdown.",
+ isRoleInUserProfileWidget(rolesInUserProfileWidget), equalTo(true));
+ assertThat("Number of the roles is not correct",
rolesInUserProfileWidget.length(),
+ equalTo(EXPECTED_ROLES));
+
+ setActiveUserRole(false);
+
+ String responseDeactivatedUserRole = doLoginRequest();
+ rolesInUserProfileWidget =
transformResponse(responseDeactivatedUserRole);
+ assertThat("The activated role is present in the dropdown.",
+ isRoleInUserProfileWidget(rolesInUserProfileWidget), equalTo(false));
+ assertThat("Number of the roles is not correct",
rolesInUserProfileWidget.length(),
+ equalTo(EXPECTED_ROLES - 1));
+ } finally {
+ setActiveUserRole(true);
+ }
+ }
+
+ private String doLoginRequest() throws Exception {
+ Map<String, String> params = new HashMap<String, String>();
+ return
doRequest("/org.openbravo.client.kernel/OBCLKER_Kernel/SessionDynamic", params,
200,
+ "POST");
+ }
+
+ /**
+ * Remove the data of the response that is not necessary for the test. Then
retrieve the data into
+ * a JSONArray.
+ *
+ * @param resp
+ * original response
+ * @return JSONArray with the roles
+ */
+ private JSONArray transformResponse(String resp) {
+ String strResponse = resp.substring(resp.indexOf(STR_START) + 6);
+ strResponse = strResponse.substring(0, strResponse.indexOf(STR_FINISH) +
1) + "}";
+ JSONObject json = null;
+ JSONArray resultRoles = null;
+ try {
+ json = new JSONObject(strResponse);
+ resultRoles = new JSONArray(json.get("valueMap").toString());
+ } catch (JSONException e) {
+ log.error("Failed transforming the response in JSONArray: {}", e);
+ }
+ return resultRoles;
+ }
+
+ private boolean isRoleInUserProfileWidget(JSONArray roles) {
+ for (int i = 0; i < roles.length(); i++) {
+ JSONObject role;
+ try {
+ role = roles.getJSONObject(i);
+ if (!TESTED_ROLE_ID.equals(role.getString("id"))) {
+ continue;
+ }
+ return true;
+ } catch (JSONException e) {
+ log.error("Failed retrieving the JSONObject from the JSONArray: {}",
e);
+ }
+ }
+ return false;
+ }
+
+ private void setActiveUserRole(boolean isActive) {
+ OBContext.setAdminMode();
+ try {
+ UserRoles userRole = OBDal.getInstance().get(UserRoles.class,
USER_ROLE_TEST);
+ userRole.setActive(isActive);
+ OBDal.getInstance().commitAndClose();
+ } finally {
+ OBContext.restorePreviousMode();
+ }
+ }
+}
\ No newline at end of file
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
