details:   https://code.openbravo.com/erp/devel/pi/rev/5f8684771e7a
changeset: 33113:5f8684771e7a
user:      Carlos Aristu <carlos.aristu <at> openbravo.com>
date:      Tue Dec 12 19:25:59 2017 +0100
summary:   related to issue 37465: initial code clean up

  - Removed the declaration of some unused variables.

diffstat:

 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
  |  19 ++++-----
 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-action-button.js
 |   4 +-
 2 files changed, 9 insertions(+), 14 deletions(-)

diffs (103 lines):

diff -r 11175c26317d -r 5f8684771e7a 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
--- 
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
       Thu Nov 30 16:56:51 2017 -0500
+++ 
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
       Tue Dec 12 19:25:59 2017 +0100
@@ -11,7 +11,7 @@
  * under the License.
  * The Original Code is Openbravo ERP.
  * The Initial Developer of the Original Code is Openbravo SLU
- * All portions are Copyright (C) 2010-2016 Openbravo SLU
+ * All portions are Copyright (C) 2010-2017 Openbravo SLU
  * All Rights Reserved.
  * Contributor(s):  ______________________________________.
  ************************************************************************
@@ -276,8 +276,7 @@
     var parts = this.getPrototype().Class.split('_'),
         len = parts.length,
         className = '_',
-        tabSet = OB.MainView.TabSet,
-        vStack, manualJS, originalClassName, processClass, processOwnerView, 
runningProcess;
+        originalClassName, processClass, processOwnerView, runningProcess;
 
     if (params.paramWindow) {
       className = className + params.processId;
@@ -315,7 +314,7 @@
   },
 
   openProcess: function (params) {
-    var processOwnerView, selectedState, processToBeOpened;
+    var processOwnerView, processToBeOpened;
     if (params.uiPattern === 'M') { // Manual UI Pattern
       try {
         if (isc.isA.Function(params.actionHandler)) {
@@ -399,7 +398,7 @@
 
   // set window specific user settings, purposely set on class level
   setWindowSettings: function (data) {
-    var i, j, defaultView, persDefaultValue, views, length, t, tab, view, 
field, button, buttonParent, //
+    var i, j, length, t, tab, view, field, button, buttonParent, //
     st, stView, stBtns, stBtn, disabledFields, personalization, 
notAccessibleProcesses, extraCallback, //
     callbackFunc, alwaysReadOnly = function (view, record, context) {
         return true;
@@ -554,7 +553,7 @@
 
   setPersonalization: function (personalization) {
     var i, defaultView, persDefaultValue, views, currentView = this.activeView 
|| this.view,
-        length, me = this;
+        length;
 
     // only personalize if there is a professional license
     if (!OB.Utilities.checkProfessionalLicense(null, true)) {
@@ -672,7 +671,7 @@
   },
 
   clearLastViewPersonalization: function () {
-    var p, length, personalization = this.getClass().personalization;
+    var p, personalization = this.getClass().personalization;
     delete this.lastViewApplied;
     if (personalization.forms) {
       for (p in personalization.forms) {
@@ -1178,13 +1177,11 @@
   },
 
   draw: function () {
-    var standardWindow = this,
-        targetEntity, ret = this.Super('draw', arguments),
+    var ret = this.Super('draw', arguments),
         i, length = this.views.length;
     if (this.targetTabId) {
       for (i = 0; i < length; i++) {
         if (this.views[i].tabId === this.targetTabId) {
-          targetEntity = this.views[i].entity;
           this.views[i].viewGrid.targetRecordId = this.targetRecordId;
           this.targetTabGrid = this.views[i].viewGrid;
           this.views[i].openDirectTabView(true);
@@ -1308,7 +1305,7 @@
   },
 
   getProcessOwnerView: function (processId) {
-    var ownerView, i, j, nActionButtons, nViews = this.views.length;
+    var i, j, nActionButtons, nViews = this.views.length;
     for (i = 0; i < nViews; i++) {
       nActionButtons = this.views[i].actionToolbarButtons.length;
       for (j = 0; j < nActionButtons; j++) {
diff -r 11175c26317d -r 5f8684771e7a 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-action-button.js
--- 
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-action-button.js
      Thu Nov 30 16:56:51 2017 -0500
+++ 
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-action-button.js
      Tue Dec 12 19:25:59 2017 +0100
@@ -11,7 +11,7 @@
  * under the License.
  * The Original Code is Openbravo ERP.
  * The Initial Developer of the Original Code is Openbravo SLU
- * All portions are Copyright (C) 2011-2015 Openbravo SLU
+ * All portions are Copyright (C) 2011-2017 Openbravo SLU
  * All Rights Reserved.
  * Contributor(s):  ______________________________________.
  ************************************************************************
@@ -159,8 +159,6 @@
         afterRefresh, isAfterRefreshAlreadyExecuted, parsePathPart, parts;
 
     afterRefresh = function () {
-      var autosaveDone = false,
-          currentRecordId, recordsAfterRefresh;
 
       if (isAfterRefreshAlreadyExecuted) {
         // To avoid multiple calls to this function when

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to