details:   https://code.openbravo.com/erp/devel/pi/rev/447278fc8b1c
changeset: 33670:447278fc8b1c
user:      Carlos Aristu <carlos.aristu <at> openbravo.com>
date:      Mon Mar 12 14:08:21 2018 +0100
summary:   related to bug 38061: don't get windowId|ISSOTRX attribute if 
windowId is null

  Micro-optimization: if the windowId is null, then do not try to retrieve the 
windowId|ISSOTRX attribute and return null immediately.

diffstat:

 
modules/org.openbravo.client.application/src/org/openbravo/client/application/OBBindings.java
 |  10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diffs (25 lines):

diff -r f8144ae28d38 -r 447278fc8b1c 
modules/org.openbravo.client.application/src/org/openbravo/client/application/OBBindings.java
--- 
a/modules/org.openbravo.client.application/src/org/openbravo/client/application/OBBindings.java
     Mon Mar 12 14:00:10 2018 +0100
+++ 
b/modules/org.openbravo.client.application/src/org/openbravo/client/application/OBBindings.java
     Mon Mar 12 14:08:21 2018 +0100
@@ -132,16 +132,16 @@
       return "Y".equalsIgnoreCase(value) || "true".equalsIgnoreCase(value);
     }
 
-    value = (String) httpSession.getAttribute(getWindowId() + "|ISSOTRX");
-    if (value != null) {
-      return "Y".equalsIgnoreCase(value) || "true".equalsIgnoreCase(value);
-    }
-
     String windowId = getWindowId();
     if (windowId == null) {
       return null;
     }
 
+    value = (String) httpSession.getAttribute(windowId + "|ISSOTRX");
+    if (value != null) {
+      return "Y".equalsIgnoreCase(value) || "true".equalsIgnoreCase(value);
+    }
+
     ApplicationDictionaryCachedStructures adcs = WeldUtils
         
.getInstanceFromStaticBeanManager(ApplicationDictionaryCachedStructures.class);
 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to