details: https://code.openbravo.com/erp/devel/pi/rev/f8bc7fbdf77e changeset: 34100:f8bc7fbdf77e user: Atul Gaware <atul.gaware <at> openbravo.com> date: Fri May 25 21:00:17 2018 +0530 summary: Fixes Issue 38551: Improve performance of Add Multiple Payments process in Financial Account window
** Clear session after processing each payment being used to create Financial Account Transaction. ** getTransactionMaxLineNo is already called to set Line No in TransactionsDao's createFinAccTransaction method so avoid it again in AddMultiplePaymentsHandler diffstat: modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddMultiplePaymentsHandler.java | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diffs (28 lines): diff -r 231186969ee7 -r f8bc7fbdf77e modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddMultiplePaymentsHandler.java --- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddMultiplePaymentsHandler.java Fri May 25 04:22:07 2018 +0530 +++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddMultiplePaymentsHandler.java Fri May 25 21:00:17 2018 +0530 @@ -11,7 +11,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU - * All portions are Copyright (C) 2015-2016 Openbravo SLU + * All portions are Copyright (C) 2015-2018 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************ @@ -64,6 +64,7 @@ for (int i = 0; i < selectedPaymentsLength; i++) { final JSONObject paymentJS = selectedPayments.getJSONObject(i); createAndProcessTransactionFromPayment(paymentJS, statementDate, dateAcct, strAccountId); + OBDal.getInstance().getSession().clear(); } // Success Message return getSuccessMessage(String.format( @@ -103,7 +104,6 @@ transaction.setTransactionDate(transactionDate); transaction.setDateAcct(acctDate); transaction.setAccount(account); - transaction.setLineNo(TransactionsDao.getTransactionMaxLineNo(account) + 10); FIN_TransactionProcess.doTransactionProcess(ACTION_PROCESS_TRANSACTION, transaction); } } finally { ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openbravo-commits mailing list Openbravo-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-commits