details: https://code.openbravo.com/erp/devel/pi/rev/8cdf0c74bec6 changeset: 34271:8cdf0c74bec6 user: Asier Lostalé <asier.lostale <at> openbravo.com> date: Fri Jul 06 12:52:33 2018 +0200 summary: related with issue 38671: removed unused parameter
field param in FIC.setValueOfColumnInRequest was always null, so no need to have it. details: https://code.openbravo.com/erp/devel/pi/rev/eed99aa47f9b changeset: 34272:eed99aa47f9b user: Asier Lostalé <asier.lostale <at> openbravo.com> date: Fri Jul 06 12:59:08 2018 +0200 summary: related to bug 38671: added context information to log in case of failure diffstat: modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java | 30 ++++------ 1 files changed, 12 insertions(+), 18 deletions(-) diffs (62 lines): diff -r fdc9ea867984 -r eed99aa47f9b modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java --- a/modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java Thu Jul 05 12:44:28 2018 +0200 +++ b/modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java Fri Jul 06 12:59:08 2018 +0200 @@ -1022,7 +1022,7 @@ List<Column> columns = getADColumnList(tab.getTable().getId()); for (Column column : columns) { - setValueOfColumnInRequest(row, null, column.getDBColumnName()); + setValueOfColumnInRequest(row, column.getDBColumnName(), tab); } } @@ -1293,21 +1293,10 @@ } } - private void setValueOfColumnInRequest(BaseOBObject obj, Field field, String columnName) { + private void setValueOfColumnInRequest(BaseOBObject obj, String columnName, Tab tab) { Entity entity = obj.getEntity(); - final Property prop; - Object currentValue; - if (field != null) { - prop = KernelUtils.getProperty(field); - if (field.getProperty() != null) { - currentValue = DalUtil.getValueFromPath(obj, field.getProperty()); - } else { - currentValue = obj.get(prop.getName()); - } - } else { - prop = entity.getPropertyByColumnName(columnName); - currentValue = obj.get(prop.getName()); - } + Property prop = entity.getPropertyByColumnName(columnName); + Object currentValue = obj.get(prop.getName()); try { if (currentValue != null && !currentValue.toString().equals("null")) { @@ -1336,8 +1325,13 @@ RequestContext.get().setRequestParameter("inp" + Sqlc.TransformaNombreColumna(columnName), null); } - } catch (Exception e) { - log.error("Couldn't get the value for column " + columnName, e); + } catch (Exception ignore) { + String msg = "Could not get value for column: " + columnName + " - tab: " + tab; + if (obj != null) { + msg += " - row: " + obj.getId(); + } + + log.error(msg, ignore); } } @@ -1361,7 +1355,7 @@ } // We also set the value of every column in the RequestContext so that it is available for // the Auxiliary Input computation - setValueOfColumnInRequest(object, null, col.getDBColumnName()); + setValueOfColumnInRequest(object, col.getDBColumnName(), tab); } } List<AuxiliaryInput> auxInputs = getAuxiliaryInputList(tab.getId()); ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openbravo-commits mailing list Openbravo-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-commits
