details: https://code.openbravo.com/erp/devel/pi/rev/a7bf0aacd4be changeset: 35121:a7bf0aacd4be user: Javier Armendáriz <javier.armendariz <at> openbravo.com> date: Mon Nov 26 17:04:23 2018 +0100 summary: Improved log statement using log4j lambda support and streams
diffstat: modules/org.openbravo.service.json/src/org/openbravo/service/json/DataEntityQueryService.java | 18 ++++----- 1 files changed, 8 insertions(+), 10 deletions(-) diffs (42 lines): diff -r bc617f478775 -r a7bf0aacd4be modules/org.openbravo.service.json/src/org/openbravo/service/json/DataEntityQueryService.java --- a/modules/org.openbravo.service.json/src/org/openbravo/service/json/DataEntityQueryService.java Fri Nov 23 10:32:52 2018 +0100 +++ b/modules/org.openbravo.service.json/src/org/openbravo/service/json/DataEntityQueryService.java Mon Nov 26 17:04:23 2018 +0100 @@ -11,7 +11,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU - * All portions are Copyright (C) 2009-2016 Openbravo SLU + * All portions are Copyright (C) 2009-2018 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************ @@ -21,7 +21,7 @@ import java.util.ArrayList; import java.util.Iterator; import java.util.List; -import java.util.Map; +import java.util.stream.Collectors; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; @@ -152,14 +152,12 @@ } obq.setFilterOnActive(isFilterOnActive()); - if (log.isDebugEnabled()) { - String params = ""; - Map<String, Object> namedParams = queryBuilder.getNamedParameters(); - for (String paramName : namedParams.keySet()) { - params += " -" + paramName + ": " + namedParams.get(paramName) + "\n"; - } - log.debug("Setting params:\n" + params); - } + log.debug("Setting params:\n{}", ()-> + queryBuilder.getNamedParameters().entrySet().stream() + .map(e -> " -" + e.getKey() + ": " + e.getValue()) + .collect(Collectors.joining("\n")) + ); + obq.setNamedParameters(queryBuilder.getNamedParameters()); return obq; _______________________________________________ Openbravo-commits mailing list Openbravo-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-commits