details: https://code.openbravo.com/erp/devel/pi/rev/699e368e6274
changeset: 35221:699e368e6274
user: Javier Armendáriz <javier.armendariz <at> openbravo.com>
date: Tue Dec 04 09:22:11 2018 +0100
summary: Fixed issue 39657: Removed unused logger getter/setter methods
Removed logger setter/getter methods as they are not used and not having them
avoids API breaks when the log framework changes. Also changed visibility of
logger as private and final.
diffstat:
src/org/openbravo/erpCommon/ad_forms/DocAmortization.java | 20
+--------
src/org/openbravo/erpCommon/ad_forms/DocBank.java | 20
+--------
src/org/openbravo/erpCommon/ad_forms/DocCash.java | 20
+--------
src/org/openbravo/erpCommon/ad_forms/DocCostAdjustment.java | 20
+--------
src/org/openbravo/erpCommon/ad_forms/DocCostAdjustmentTemplate.java | 9 +---
src/org/openbravo/erpCommon/ad_forms/DocDPManagement.java | 20
+--------
src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java | 20
+--------
src/org/openbravo/erpCommon/ad_forms/DocInOut.java | 20
+--------
src/org/openbravo/erpCommon/ad_forms/DocInternalConsumption.java | 21
+--------
src/org/openbravo/erpCommon/ad_forms/DocInventory.java | 20
+--------
src/org/openbravo/erpCommon/ad_forms/DocInvoice.java | 20
+--------
src/org/openbravo/erpCommon/ad_forms/DocLCCost.java | 20
+--------
src/org/openbravo/erpCommon/ad_forms/DocLandedCost.java | 20
+--------
src/org/openbravo/erpCommon/ad_forms/DocLine_LCCost.java | 9 +---
src/org/openbravo/erpCommon/ad_forms/DocLine_LandedCost.java | 9 +---
src/org/openbravo/erpCommon/ad_forms/DocLine_Payment.java | 20
+---------
src/org/openbravo/erpCommon/ad_forms/DocMatchInv.java | 20
+--------
src/org/openbravo/erpCommon/ad_forms/DocMovement.java | 20
+--------
src/org/openbravo/erpCommon/ad_forms/DocOrder.java | 20
+--------
src/org/openbravo/erpCommon/ad_forms/DocPayment.java | 20
+--------
src/org/openbravo/erpCommon/ad_forms/DocProduction.java | 20
+--------
src/org/openbravo/erpCommon/ad_forms/Translation.java | 10 +----
22 files changed, 56 insertions(+), 342 deletions(-)
diffs (truncated from 916 to 300 lines):
diff -r c2915cbd83ab -r 699e368e6274
src/org/openbravo/erpCommon/ad_forms/DocAmortization.java
--- a/src/org/openbravo/erpCommon/ad_forms/DocAmortization.java Tue Dec 11
19:19:27 2018 +0000
+++ b/src/org/openbravo/erpCommon/ad_forms/DocAmortization.java Tue Dec 04
09:22:11 2018 +0100
@@ -24,7 +24,8 @@
import javax.servlet.ServletException;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import org.openbravo.base.secureApp.VariablesSecureApp;
import org.openbravo.data.FieldProvider;
import org.openbravo.database.ConnectionProvider;
@@ -32,7 +33,7 @@
public class DocAmortization extends AcctServer {
private static final long serialVersionUID = 1L;
- static Logger log4jDocAmortization = Logger.getLogger(DocAmortization.class);
+ private static final Logger log4jDocAmortization = LogManager.getLogger();
private String SeqNo = "0";
/** Account Type - Asset */
@@ -66,21 +67,6 @@
}
/**
- * @return the log4jDocAmortization
- */
- public static Logger getLog4jDocAmortization() {
- return log4jDocAmortization;
- }
-
- /**
- * @param log4jDocAmortization
- * the log4jDocAmortization to set
- */
- public static void setLog4jDocAmortization(Logger log4jDocAmortization) {
- DocAmortization.log4jDocAmortization = log4jDocAmortization;
- }
-
- /**
* @return the seqNo
*/
public String getSeqNo() {
diff -r c2915cbd83ab -r 699e368e6274
src/org/openbravo/erpCommon/ad_forms/DocBank.java
--- a/src/org/openbravo/erpCommon/ad_forms/DocBank.java Tue Dec 11 19:19:27
2018 +0000
+++ b/src/org/openbravo/erpCommon/ad_forms/DocBank.java Tue Dec 04 09:22:11
2018 +0100
@@ -22,7 +22,8 @@
import javax.servlet.ServletException;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import org.openbravo.base.secureApp.VariablesSecureApp;
import org.openbravo.data.FieldProvider;
import org.openbravo.database.ConnectionProvider;
@@ -30,22 +31,7 @@
public class DocBank extends AcctServer {
private static final long serialVersionUID = 1L;
- static Logger log4jDocBank = Logger.getLogger(DocBank.class);
-
- /**
- * @return the log4jDocBank
- */
- public static Logger getLog4jDocBank() {
- return log4jDocBank;
- }
-
- /**
- * @param log4jDocBank
- * the log4jDocBank to set
- */
- public static void setLog4jDocBank(Logger log4jDocBank) {
- DocBank.log4jDocBank = log4jDocBank;
- }
+ private static final Logger log4jDocBank = LogManager.getLogger();
/**
* @return the seqNo
diff -r c2915cbd83ab -r 699e368e6274
src/org/openbravo/erpCommon/ad_forms/DocCash.java
--- a/src/org/openbravo/erpCommon/ad_forms/DocCash.java Tue Dec 11 19:19:27
2018 +0000
+++ b/src/org/openbravo/erpCommon/ad_forms/DocCash.java Tue Dec 04 09:22:11
2018 +0100
@@ -22,7 +22,8 @@
import javax.servlet.ServletException;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import org.openbravo.base.secureApp.VariablesSecureApp;
import org.openbravo.data.FieldProvider;
import org.openbravo.database.ConnectionProvider;
@@ -32,21 +33,6 @@
private static final long serialVersionUID = 1L;
/**
- * @return the log4jDocCash
- */
- public static Logger getLog4jDocCash() {
- return log4jDocCash;
- }
-
- /**
- * @param log4jDocCash
- * the log4jDocCash to set
- */
- public static void setLog4jDocCash(Logger log4jDocCash) {
- DocCash.log4jDocCash = log4jDocCash;
- }
-
- /**
* @return the seqNo
*/
public String getSeqNo() {
@@ -68,7 +54,7 @@
return serialVersionUID;
}
- static Logger log4jDocCash = Logger.getLogger(DocCash.class);
+ private static final Logger log4jDocCash = LogManager.getLogger();
private String SeqNo = "0";
diff -r c2915cbd83ab -r 699e368e6274
src/org/openbravo/erpCommon/ad_forms/DocCostAdjustment.java
--- a/src/org/openbravo/erpCommon/ad_forms/DocCostAdjustment.java Tue Dec
11 19:19:27 2018 +0000
+++ b/src/org/openbravo/erpCommon/ad_forms/DocCostAdjustment.java Tue Dec
04 09:22:11 2018 +0100
@@ -25,7 +25,8 @@
import javax.servlet.ServletException;
import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import org.openbravo.base.secureApp.VariablesSecureApp;
import org.openbravo.data.FieldProvider;
import org.openbravo.database.ConnectionProvider;
@@ -35,7 +36,7 @@
public class DocCostAdjustment extends AcctServer {
private static final long serialVersionUID = 1L;
- static Logger log4jDocCostAdjustment =
Logger.getLogger(DocCostAdjustment.class);
+ private static final Logger log4jDocCostAdjustment = LogManager.getLogger();
/** AD_Table_ID */
private String SeqNo = "0";
@@ -365,21 +366,6 @@
} // createFact
/**
- * @return the log4jDocCostAdjustment
- */
- public static Logger getlog4jDocCostAdjustment() {
- return log4jDocCostAdjustment;
- }
-
- /**
- * @param log4jDocCostAdjustment
- * the log4jDocCostAdjustment to set
- */
- public static void setlog4jDocCostAdjustment(Logger log4jDocCostAdjustment) {
- DocCostAdjustment.log4jDocCostAdjustment = log4jDocCostAdjustment;
- }
-
- /**
* @return the seqNo
*/
public String getSeqNo() {
diff -r c2915cbd83ab -r 699e368e6274
src/org/openbravo/erpCommon/ad_forms/DocCostAdjustmentTemplate.java
--- a/src/org/openbravo/erpCommon/ad_forms/DocCostAdjustmentTemplate.java
Tue Dec 11 19:19:27 2018 +0000
+++ b/src/org/openbravo/erpCommon/ad_forms/DocCostAdjustmentTemplate.java
Tue Dec 04 09:22:11 2018 +0100
@@ -11,7 +11,7 @@
* under the License.
* The Original Code is Openbravo ERP.
* The Initial Developer of the Original Code is Openbravo SLU
- * All portions are Copyright (C) 2014 Openbravo SLU
+ * All portions are Copyright (C) 2014-2018 Openbravo SLU
* All Rights Reserved.
* Contributor(s): ______________________________________.
*************************************************************************
@@ -22,14 +22,11 @@
import javax.servlet.ServletException;
-import org.apache.logging.log4j.LogManager;
-import org.apache.logging.log4j.Logger;
import org.openbravo.base.secureApp.VariablesSecureApp;
import org.openbravo.database.ConnectionProvider;
public abstract class DocCostAdjustmentTemplate {
private static final long serialVersionUID = 1L;
- private static final Logger log4jDocCostAdjustment = LogManager.getLogger();
/**
* Constructor
@@ -59,10 +56,6 @@
public abstract Fact createFact(DocCostAdjustment docCostAdjustment,
AcctSchema as,
ConnectionProvider conn, Connection con, VariablesSecureApp vars) throws
ServletException;
- public static Logger getLog4jdoccostadjustment() {
- return log4jDocCostAdjustment;
- }
-
public static long getSerialversionuid() {
return serialVersionUID;
}
diff -r c2915cbd83ab -r 699e368e6274
src/org/openbravo/erpCommon/ad_forms/DocDPManagement.java
--- a/src/org/openbravo/erpCommon/ad_forms/DocDPManagement.java Tue Dec 11
19:19:27 2018 +0000
+++ b/src/org/openbravo/erpCommon/ad_forms/DocDPManagement.java Tue Dec 04
09:22:11 2018 +0100
@@ -24,7 +24,8 @@
import javax.servlet.ServletException;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
import org.openbravo.base.secureApp.VariablesSecureApp;
import org.openbravo.data.FieldProvider;
import org.openbravo.database.ConnectionProvider;
@@ -32,26 +33,11 @@
public class DocDPManagement extends AcctServer {
private static final long serialVersionUID = 1L;
- private static Logger docDPManagementLog4j =
Logger.getLogger(DocDPManagement.class);
+ private static final Logger docDPManagementLog4j = LogManager.getLogger();
private String SeqNo = "0";
/**
- * @return the docDPManagementLog4j
- */
- public static Logger getLog4j() {
- return docDPManagementLog4j;
- }
-
- /**
- * @param docDPManagementLog4j
- * the docDPManagementLog4j to set
- */
- public static void setLog4j(Logger docDPManagementLog4j) {
- DocDPManagement.docDPManagementLog4j = docDPManagementLog4j;
- }
-
- /**
* @return the seqNo
*/
public String getSeqNo() {
diff -r c2915cbd83ab -r 699e368e6274
src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java
--- a/src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java Tue Dec 11
19:19:27 2018 +0000
+++ b/src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java Tue Dec 04
09:22:11 2018 +0100
@@ -23,7 +23,8 @@
import javax.servlet.ServletException;
import org.apache.commons.lang.StringUtils;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import org.openbravo.base.secureApp.VariablesSecureApp;
import org.openbravo.dal.core.OBContext;
import org.openbravo.dal.service.OBDal;
@@ -34,7 +35,7 @@
public class DocGLJournal extends AcctServer {
private static final long serialVersionUID = 1L;
- static Logger log4jDocGLJournal = Logger.getLogger(DocGLJournal.class);
+ private static final Logger log4jDocGLJournal = LogManager.getLogger();
private String SeqNo = "0";
private String C_AcctSchema_ID;
@@ -207,21 +208,6 @@
} // createFact
/**
- * @return the log4jDocGLJournal
- */
- public static Logger getLog4jDocGLJournal() {
- return log4jDocGLJournal;
- }
-
- /**
- * @param log4jDocGLJournal
- * the log4jDocGLJournal to set
- */
- public static void setLog4jDocGLJournal(Logger log4jDocGLJournal) {
- DocGLJournal.log4jDocGLJournal = log4jDocGLJournal;
- }
-
- /**
* @return the seqNo
*/
public String getSeqNo() {
diff -r c2915cbd83ab -r 699e368e6274
src/org/openbravo/erpCommon/ad_forms/DocInOut.java
--- a/src/org/openbravo/erpCommon/ad_forms/DocInOut.java Tue Dec 11
19:19:27 2018 +0000
+++ b/src/org/openbravo/erpCommon/ad_forms/DocInOut.java Tue Dec 04
09:22:11 2018 +0100
@@ -26,7 +26,8 @@
import javax.servlet.ServletException;
-import org.apache.log4j.Logger;
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
