details: https://code.openbravo.com/erp/devel/pi/rev/7aada5d51e10 changeset: 35251:7aada5d51e10 user: Asier Lostalé <asier.lostale <at> openbravo.com> date: Mon Dec 17 13:59:23 2018 +0100 summary: related with issue 39755: give some time to complete the thread
details: https://code.openbravo.com/erp/devel/pi/rev/b8fc66a7be6e changeset: 35252:b8fc66a7be6e user: Asier Lostalé <asier.lostale <at> openbravo.com> date: Mon Dec 17 14:38:00 2018 +0100 summary: fixed bug 39821: StackOverflowError in P&E having 100+ records selected Do not decrease page fetch size as it can have been increased by previous call. diffstat: modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java | 3 ++- src-test/src/org/openbravo/test/dal/DalLockingTest.java | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diffs (25 lines): diff -r ed422035576d -r b8fc66a7be6e modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java --- a/modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java Mon Dec 17 12:46:08 2018 +0000 +++ b/modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java Mon Dec 17 14:38:00 2018 +0100 @@ -422,7 +422,8 @@ int startRow = Integer.parseInt(startRowStr); int endRow = Integer.parseInt(endRowStr); int selectedRecords = DataSourceUtils.getNumberOfSelectedRecords(parameters); - if (startRow == 0 && endRow != -1 && selectedRecords > JsonConstants.PAE_DATA_PAGE_SIZE) { + if (startRow == 0 && endRow != -1 && selectedRecords > JsonConstants.PAE_DATA_PAGE_SIZE + && selectedRecords > endRow) { return Integer.toString(selectedRecords); } return endRowStr; diff -r ed422035576d -r b8fc66a7be6e src-test/src/org/openbravo/test/dal/DalLockingTest.java --- a/src-test/src/org/openbravo/test/dal/DalLockingTest.java Mon Dec 17 12:46:08 2018 +0000 +++ b/src-test/src/org/openbravo/test/dal/DalLockingTest.java Mon Dec 17 14:38:00 2018 +0100 @@ -146,7 +146,7 @@ gotRule.countDown(); waitUnitl(ruleModified); lockedName.append(OBDal.getInstance().getObjectLockForNoKeyUpdate(ar).getName()); - }, "T1", 0), // + }, "T1", 50), // doWithDAL(() -> { getTestingAlertRule().setName("Modified"); OBDal.getInstance().commitAndClose(); _______________________________________________ Openbravo-commits mailing list Openbravo-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-commits
