details: https://code.openbravo.com/erp/devel/pi/rev/053a02c45e1f
changeset: 35259:053a02c45e1f
user: Carlos Aristu <carlos.aristu <at> openbravo.com>
date: Thu Dec 20 17:14:44 2018 +0100
summary: related to bug 39644: Minor code improvements
- Update copyright year
- Remove unused parameter
diffstat:
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceUtils.java
| 2 +-
modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
| 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diffs (44 lines):
diff -r 0dc6820e006c -r 053a02c45e1f
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceUtils.java
---
a/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceUtils.java
Tue Dec 18 10:48:18 2018 +0530
+++
b/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceUtils.java
Thu Dec 20 17:14:44 2018 +0100
@@ -11,7 +11,7 @@
* under the License.
* The Original Code is Openbravo ERP.
* The Initial Developer of the Original Code is Openbravo SLU
- * All portions are Copyright (C) 2014 Openbravo SLU
+ * All portions are Copyright (C) 2014-2018 Openbravo SLU
* All Rights Reserved.
* Contributor(s): ______________________________________.
************************************************************************
diff -r 0dc6820e006c -r 053a02c45e1f
modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
---
a/modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
Tue Dec 18 10:48:18 2018 +0530
+++
b/modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
Thu Dec 20 17:14:44 2018 +0100
@@ -256,7 +256,7 @@
// If the request is done from a P&E window, then we should adapt
the page size to include
// all selected records into the response
if (isPickAndEdit) {
- if (shouldIncreasePageSize(parameters, bobs, startRowStr,
endRowStr)) {
+ if (shouldIncreasePageSize(bobs, startRowStr, endRowStr)) {
String newEndRow = Integer.toString(Integer.parseInt(endRowStr)
+ JsonConstants.PAE_DATA_PAGE_SIZE);
parameters.put(JsonConstants.ENDROW_PARAMETER, newEndRow);
@@ -436,8 +436,6 @@
* to the the selection status of the last record returned by the database
query and the current
* page size.
*
- * @param parameters
- * map of request parameters
* @param bobs
* list of objects returned by the database query
* @param startRowStr
@@ -446,8 +444,8 @@
* end row of the page
* @return true if the page size should be increased, false otherwise
*/
- private boolean shouldIncreasePageSize(Map<String, String> parameters,
List<BaseOBObject> bobs,
- String startRowStr, String endRowStr) {
+ private boolean shouldIncreasePageSize(List<BaseOBObject> bobs, String
startRowStr,
+ String endRowStr) {
if (startRowStr == null || endRowStr == null) {
return false;
}
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
