[OpenbravoERP-commits] devel/pi: related to issue 37940: minor code cleanup

[hg]

details:   https://code.openbravo.com/erp/devel/pi/rev/88d362c8aba0
changeset: 35321:88d362c8aba0
user:      Carlos Aristu <carlos.aristu <at> openbravo.com>
date:      Wed Jan 16 11:06:26 2019 +0100
summary:   related to issue 37940: minor code cleanup

  - Removed unused variables
  - Declared "obj" variables on top of the function
  - Remove unreachable "return false"

diffstat:

 web/js/login.js |  17 +++++++----------
 1 files changed, 7 insertions(+), 10 deletions(-)

diffs (76 lines):

diff -r 3277f851fae8 -r 88d362c8aba0 web/js/login.js
--- a/web/js/login.js   Wed Jan 16 09:37:56 2019 +0100
+++ b/web/js/login.js   Wed Jan 16 11:06:26 2019 +0100
@@ -116,8 +116,7 @@
 }
 
 function processResult(result) {
-  var target = '_self',
-      command, shouldContinue = true;
+  var shouldContinue = true;
   if (result.showMessage) {
     shouldContinue = setLoginMessage(result.messageType, result.messageTitle, 
result.messageText);
     if (!shouldContinue) {
@@ -239,7 +238,6 @@
 function checkBrowserCompatibility() {
   var browserName = getBrowserInfo('name');
   var browserVersion = getBrowserInfo('version');
-  var browserMajorVersion = getBrowserInfo('majorVersion');
   var isValid = false;
   if (browserName.toUpperCase().indexOf('FIREFOX') != -1 || 
browserName.toUpperCase().indexOf('ICEWEASEL') != -1) {
     if (browserVersionToFloat(browserVersion) >= 
browserVersionToFloat(validBrowserFirefox)) {
@@ -268,7 +266,6 @@
 function checkRecommendedBrowser() {
   var browserName = getBrowserInfo('name');
   var browserVersion = getBrowserInfo('version');
-  var browserMajorVersion = getBrowserInfo('majorVersion');
   var isRecommended = false;
   if (browserName.toUpperCase().indexOf('FIREFOX') != -1 || 
browserName.toUpperCase().indexOf('ICEWEASEL') != -1) {
     if (browserVersionToFloat(browserVersion) >= 
browserVersionToFloat(recBrowserFirefox)) {
@@ -366,7 +363,6 @@
 }
 
 function onLoadDo() {
-  var msgContainer = document.getElementById('errorMsg');
   var msgContainerTitle = document.getElementById('errorMsgTitle');
   var msgContainerTitleContainer = 
document.getElementById('errorMsgTitle_Container');
   var msgContainerContent = document.getElementById('errorMsgContent');
@@ -491,11 +487,12 @@
 }
 
 function disableAttributeWithFunction(element, type, attribute) {
+  var obj;
   if (type == 'obj') {
-    var obj = element;
+    obj = element;
   }
   if (type == 'id') {
-    var obj = document.getElementById(element);
+    obj = document.getElementById(element);
   }
   var attribute_text = getObjAttribute(obj, attribute);
   attribute_text = 'return true; tmp_water_mark; ' + attribute_text;
@@ -503,11 +500,12 @@
 }
 
 function enableAttributeWithFunction(element, type, attribute) {
+  var obj;
   if (type == 'obj') {
-    var obj = element;
+    obj = element;
   }
   if (type == 'id') {
-    var obj = document.getElementById(element);
+    obj = document.getElementById(element);
   }
   var attribute_text = getObjAttribute(obj, attribute);
   attribute_text = attribute_text.replace('return true; tmp_water_mark; ', '')
@@ -618,7 +616,6 @@
       }
       return false;
     }
-    return false;
   }
   return false;
 }
\ No newline at end of file


_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits