details:   https://code.openbravo.com/erp/devel/pi/rev/9195e827f97c
changeset: 35359:9195e827f97c
user:      Atul Gaware <atul.gaware <at> openbravo.com>
date:      Thu Jan 24 16:07:24 2019 +0530
summary:   Fixes Issue 39986:Invoice status in goods shipment is not correctly
calculated in some circumstances

** When calculating invoice status sum of absolute value of quantities
should be considered to have proper invoice status values. If
quantities are combination of positive and negative values then simple
sum will produce wrong results.

diffstat:

 src-db/database/model/functions/C_GETINVOICESTATUSFROMSHIPMENT.xml |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (24 lines):

diff -r aea5c08b7cf2 -r 9195e827f97c 
src-db/database/model/functions/C_GETINVOICESTATUSFROMSHIPMENT.xml
--- a/src-db/database/model/functions/C_GETINVOICESTATUSFROMSHIPMENT.xml        
Thu Jan 24 10:25:44 2019 +0100
+++ b/src-db/database/model/functions/C_GETINVOICESTATUSFROMSHIPMENT.xml        
Thu Jan 24 16:07:24 2019 +0530
@@ -16,17 +16,17 @@
 * under the License.
 * The Original Code is Openbravo ERP.
 * The Initial Developer of the Original Code is Openbravo SLU
-* All portions are Copyright (C) 2012-2018 Openbravo SLU
+* All portions are Copyright (C) 2012-2019 Openbravo SLU
 * All Rights Reserved.
 * Contributor(s):  ______________________________________.
 ************************************************************************/
 v_percent NUMBER:=0;
 BEGIN
 select case when min(a.suma) = 0 then 0 
-         else round(coalesce(sum(inv.qtyinvoiced), 0)/min(a.suma) * 100, 0) 
end INTO v_percent
+         else round(coalesce(sum(abs(inv.qtyinvoiced)), 0)/min(a.suma) * 100, 
0) end INTO v_percent
 from m_inoutline minline 
 join c_invoiceline inv on minline.m_inoutline_id=inv.m_inoutline_id,
- (select COALESCE(sum(g.movementqty), 0) as suma
+ (select COALESCE(sum(abs(g.movementqty)), 0) as suma
       from m_inoutline g where g.m_inout_id =p_minoutid) a
 where minline.m_inout_id=p_minoutid
 and exists (select 1 from c_invoice i where i.c_invoice_id = inv.c_invoice_id


_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to