details: https://code.openbravo.com/erp/devel/pi/rev/6b45cce606e0
changeset: 35464:6b45cce606e0
user: Javier Armend=E1riz <javier.armendariz <at> openbravo.com>
date: Wed Feb 20 10:42:06 2019 +0100
summary: Fixed issue 40180: Wrong tab behavior on grid view in Firefox 65=
+.
Applied a patch from latest Smartclient 12 code that prevents that keypress
events are fired twice for tab key in Firefox 65+.
diffstat:
modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinte=
rface.smartclient/isomorphic/ISC_Combined.js | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diffs (13 lines):
diff -r 345f70ecc833 -r 6b45cce606e0 modules/org.openbravo.userinterface.sm=
artclient/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combin=
ed.js
--- a/modules/org.openbravo.userinterface.smartclient/web/org.openbravo.use=
rinterface.smartclient/isomorphic/ISC_Combined.js Wed Feb 20 18:22:12
2019 =
+0100
+++ b/modules/org.openbravo.userinterface.smartclient/web/org.openbravo.use=
rinterface.smartclient/isomorphic/ISC_Combined.js Wed Feb 20 10:42:06
2019 =
+0100
@@ -1116,7 +1116,8 @@
if(_5!=3Dfalse&&_4.keyName){_3.$85t[_3.$85t.length]=3D_4.keyName}
_3.$885=3D_4.ctrlKey;_3.$886=3D_4.altKey;if(_5!=3Dfalse&&_11){_5=3D_3.hand=
leKeyPress(_1);_3.$85z[_4.keyName]=3Dtrue}
if(_5=3D=3Dfalse){this.cancelKeyEvent(_1)}
-return _5},isc.A.$90x=3Dfunction isc_c_EventHandler__fireKeypressOnKeyDown=
(_1){return false},isc.A.$947=3Dfunction isc_c_EventHandler__mozFireKeypres=
sOnKeyDown(_1){return _1=3D=3Dthis.$je&&this.shiftKeyDown()},isc.A.$948=3Df=
unction isc_c_EventHandler__ieFireKeypressOnKeyDown(_1){var _2=3Disc.EH;if(=
_2.$i8[_1]!=3Dnull)return true;return _2.$944[_1]!=3Dnull&&_2.$949()},isc.A=
.$95a=3Dfunction isc_c_EventHandler__safariFireKeypressOnKeyDown(_1){var _2=
=3Disc.EH;if(_2.$90v[_1]!=3Dnull)return true;return _2.$944[_1]!=3Dnull&&_2=
.$949()},isc.A.$949=3Dfunction isc_c_EventHandler__modifierKeyDownOnly(_1){=
if(!_1)_1=3Dthis.lastEvent;if(isc.Browser.isMac)return _1.metaKey&&!_1.altK=
ey&&!_1.shiftKey;else return _1.ctrlKey&&!_1.metaKey&&!_1.altKey&&!_1.shift=
Key},isc.A.handleKeyDown=3Dfunction isc_c_EventHandler_handleKeyDown(_1,_2)=
{var _3=3Disc.EH,_4=3D_3.lastEvent,_5;var _6=3D_3.eventHandledNatively(_4.e=
ventType,_4.nativeKeyTarget);if(_6)_5=3D_3.$js;if(_2!=3Dnull)isc.addPropert=
ies(_4,_2);if(!_6){var _7=3D[_4,_4.target,_4.keyName];var _8=3D_4.keyTarget=
;if(_8=3D=3Dnull)_8=3Dthis.getEventTargetCanvas(_1,_4.nativeKeyTarget);if(_=
3.targetIsEnabled(_8)){_5=3D(_3.bubbleEvent(_8,_3.KEY_DOWN,_7)!=3Dfalse)}}
+return _5},isc.A.$90x=3Dfunction isc_c_EventHandler__fireKeypressOnKeyDown=
(_1){return false},isc.A.$947=3Dfunction isc_c_EventHandler__mozFireKeypres=
sOnKeyDown(_1){if(isc.Browser.isMoz&&isc.Browser.version>=3D65){if(_1=3D=3D=
this.$jf)return true}
+return _1=3D=3Dthis.$je&&this.shiftKeyDown()},isc.A.$948=3Dfunction isc_c_=
EventHandler__ieFireKeypressOnKeyDown(_1){var _2=3Disc.EH;if(_2.$i8[_1]!=3D=
null)return true;return _2.$944[_1]!=3Dnull&&_2.$949()},isc.A.$95a=3Dfuncti=
on isc_c_EventHandler__safariFireKeypressOnKeyDown(_1){var _2=3Disc.EH;if(_=
2.$90v[_1]!=3Dnull)return true;return _2.$944[_1]!=3Dnull&&_2.$949()},isc.A=
.$949=3Dfunction isc_c_EventHandler__modifierKeyDownOnly(_1){if(!_1)_1=3Dth=
is.lastEvent;if(isc.Browser.isMac)return _1.metaKey&&!_1.altKey&&!_1.shiftK=
ey;else return _1.ctrlKey&&!_1.metaKey&&!_1.altKey&&!_1.shiftKey},isc.A.han=
dleKeyDown=3Dfunction isc_c_EventHandler_handleKeyDown(_1,_2){var _3=3Disc.=
EH,_4=3D_3.lastEvent,_5;var _6=3D_3.eventHandledNatively(_4.eventType,_4.na=
tiveKeyTarget);if(_6)_5=3D_3.$js;if(_2!=3Dnull)isc.addProperties(_4,_2);if(=
!_6){var _7=3D[_4,_4.target,_4.keyName];var _8=3D_4.keyTarget;if(_8=3D=3Dnu=
ll)_8=3Dthis.getEventTargetCanvas(_1,_4.nativeKeyTarget);if(_3.targetIsEnab=
led(_8)){_5=3D(_3.bubbleEvent(_8,_3.KEY_DOWN,_7)!=3Dfalse)}}
return _5},isc.A.$kb=3Dfunction isc_c_EventHandler__handleNativeKeyUp(_1){=
if(!isc.Page.isLoaded())return false;var _2=3Disc.EH,_3=3D_2.lastEvent;if(!=
_1)_1=3D_2.getWindow().event;_2.getKeyEventProperties(_1);_2.$885=3D_3.ctrl=
Key
_2.$886=3D_3.altKey
_2.$85z[_3.keyName]=3Dnull;if(_2.$85t.indexOf(_2.lastEvent.keyName)!=3D-1)=
{if(_2.handleKeyPress(_1)=3D=3Dfalse){this.cancelKeyEvent(_1);return false}}
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
