details: https://code.openbravo.com/erp/devel/pi/rev/976e03344470
changeset: 35468:976e03344470
user: Asier Lostalé <asier.lostale <at> openbravo.com>
date: Fri Feb 22 12:43:45 2019 +0100
summary: fixed issue 40179: column validations don't show proper message
When a column validation is not satisfied a usless message is displayed.
The message was correctly generated in the backend but not displayed in
fronted.
diffstat:
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
| 14 +++++----
1 files changed, 8 insertions(+), 6 deletions(-)
diffs (32 lines):
diff -r 965c58c02c48 -r 976e03344470
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
Fri Feb 22 10:24:47 2019 +0100
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
Fri Feb 22 12:43:45 2019 +0100
@@ -1918,7 +1918,7 @@
handleFieldErrors: function (errors) {
var msg, additionalMsg = '',
- err, errorFld;
+ err, errorFld, errorMsg;
if (this.view.isEditingGrid) {
msg = OB.I18N.getLabel('OBUIAPP_ErrorInFieldsGrid', [this.view.ID]);
@@ -1931,12 +1931,14 @@
for (err in errors) {
if (errors.hasOwnProperty(err)) {
var fld = this.getField(err);
- if (!fld || !fld.visible) {
- if (additionalMsg !== '') {
- additionalMsg = additionalMsg + '<br/>';
- }
- additionalMsg = additionalMsg + errors[err];
+ if (additionalMsg !== '') {
+ additionalMsg = additionalMsg + '<br/>';
}
+ errorMsg = errors[err];
+ if (fld && fld.getTitle()) {
+ errorMsg = errorMsg.replace(err, fld.getTitle());
+ }
+ additionalMsg = additionalMsg + errorMsg;
}
}
if (additionalMsg) {
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
