details: https://code.openbravo.com/erp/devel/pi/rev/372e1bed6b76
changeset: 35474:372e1bed6b76
user: Javier Armendáriz <javier.armendariz <at> openbravo.com>
date: Thu Feb 28 10:53:54 2019 +0100
summary: Fixed issue 40253: RemoteCallManager response not handled when
timemout is fired.
Removed result sanitizing in RPCManager. This makes timeout message appears but
also marks the request as complete and the actual response is not processed when
it arrives.
diffstat:
modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
| 17 ++-------
1 files changed, 4 insertions(+), 13 deletions(-)
diffs (29 lines):
diff -r aed4d4a47cd1 -r 372e1bed6b76
modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
a/modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
Wed Feb 27 10:31:10 2019 +0100
+++
b/modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
Thu Feb 28 10:53:54 2019 +0100
@@ -813,21 +813,12 @@
_originalEvalResult: isc.RPCManager.evalResult,
evalResult: function (request, response, results) {
- if (response.status !== isc.RPCResponse.STATUS_SUCCESS) {
- if (isc.isA.Function(request.errorCallback)) {
- // if the response contains an error status, call the errorCallback
- request.errorCallback(request, response);
- } else {
- // try to handle the error in the standard way
- this.handleError(response, request);
- }
+ if (response.status !== isc.RPCResponse.STATUS_SUCCESS &&
isc.isA.Function(request.errorCallback)) {
+ // if the response contains an error status, call the errorCallback
+ request.errorCallback(request, response);
}
- return this._originalEvalResult(request, response,
this.sanitizeResults(results));
- },
-
- sanitizeResults: function (results) {
- return isc.isA.Object(results) ? JSON.stringify(results) : results;
+ return this._originalEvalResult(request, response, results);
},
// Escape characters that are not properly handled in JavaScript's eval. See
issue #36788.
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
