details: https://code.openbravo.com/erp/devel/pi/rev/8babe1f19082
changeset: 35655:8babe1f19082
user: Stefan Huehner <stefan.huehner <at> openbravo.com>
date: Tue Apr 16 09:38:15 2019 +0200
summary: Fixed issue 40599 Stop using Vector<Object> where not useful as its
bad coding style
diffstat:
modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java
| 7 ++-----
src/org/openbravo/common/actionhandler/CashflowForecastReportActionHandler.java
| 2 +-
2 files changed, 3 insertions(+), 6 deletions(-)
diffs (35 lines):
diff -r 2ccef54104f1 -r 8babe1f19082
modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java
---
a/modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java
Fri Apr 12 14:54:40 2019 +0200
+++
b/modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java
Tue Apr 16 09:38:15 2019 +0200
@@ -2124,17 +2124,14 @@
}
public static FieldProvider[] getObjectList(String objectNames) {
- Vector<Object> vector = new Vector<Object>(0);
if (StringUtils.isEmpty(objectNames)) {
- FieldProvider objectListData[] = new FieldProvider[vector.size()];
- vector.copyInto(objectListData);
-
- return objectListData;
+ return new FieldProvider[0];
} else {
String[] names = objectNames.substring(1, objectNames.length() -
1).split(", ");
SQLReturnObject sqlRO;
String name = null;
+ Vector<FieldProvider> vector = new Vector<>(0);
for (int i = 0; i < names.length; i++) {
sqlRO = new SQLReturnObject();
names[i] = names[i];
diff -r 2ccef54104f1 -r 8babe1f19082
src/org/openbravo/common/actionhandler/CashflowForecastReportActionHandler.java
---
a/src/org/openbravo/common/actionhandler/CashflowForecastReportActionHandler.java
Fri Apr 12 14:54:40 2019 +0200
+++
b/src/org/openbravo/common/actionhandler/CashflowForecastReportActionHandler.java
Tue Apr 16 09:38:15 2019 +0200
@@ -126,7 +126,7 @@
private Map<String, Object> obtainLinesFieldProvider(CashflowForecastData[]
dataSummary,
String strDatePlanned, boolean breakByDate, VariablesSecureApp vars,
ConnectionProvider conn)
throws ServletException {
- Vector<Object> vDatas = new Vector<Object>();
+ Vector<CashflowForecastData[]> vDatas = new Vector<>();
Vector<Object> vHeader = new Vector<Object>();
CashflowForecastData[] dataDetail = null;
CashflowForecastData[][] data = null;
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
