details: https://code.openbravo.com/erp/devel/pi/rev/3f7bc51bb14f
changeset: 35714:3f7bc51bb14f
user: Carlos Aristu <carlos.aristu <at> openbravo.com>
date: Mon May 06 12:12:55 2019 +0200
summary: related to issue 40735: minor code improvements
- Update copyright year
- Removed duplicated null check for "record"
- Initialize "i" when needed
- Remove useless assignment to "drawArea"
diffstat:
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
| 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diffs (40 lines):
diff -r 3d7237675ba2 -r 3f7bc51bb14f
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
Mon May 06 09:33:11 2019 +0200
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
Mon May 06 12:12:55 2019 +0200
@@ -11,7 +11,7 @@
* under the License.
* The Original Code is Openbravo ERP.
* The Initial Developer of the Original Code is Openbravo SLU
- * All portions are Copyright (C) 2010-2018 Openbravo SLU
+ * All portions are Copyright (C) 2010-2019 Openbravo SLU
* All Rights Reserved.
* Contributor(s): ______________________________________.
************************************************************************
@@ -137,7 +137,7 @@
return OB.Utilities.getPromptString(cellErrors);
}
}
- if (record && record[isc.OBViewGrid.ERROR_MESSAGE_PROP]) {
+ if (record[isc.OBViewGrid.ERROR_MESSAGE_PROP]) {
return record[isc.OBViewGrid.ERROR_MESSAGE_PROP];
}
@@ -823,8 +823,7 @@
},
clearFilter: function (keepFilterClause, noPerformAction) {
- var i = 0,
- fld, length, groupState, forceRefresh;
+ var i, fld, length, groupState, forceRefresh;
if (this.lazyFiltering) {
noPerformAction = true;
if (this.sorter) {
@@ -1572,7 +1571,7 @@
newDrawArea = this.getDrawArea();
drawArea = this._oldDrawArea;
if (!drawArea) {
- drawArea = this._oldDrawArea = [0, 0, 0, 0];
+ this._oldDrawArea = [0, 0, 0, 0];
}
firstRecord = grid.getRecord(newDrawArea[0]);
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
