details: https://code.openbravo.com/erp/devel/pi/rev/8671a3b792ff
changeset: 35916:8671a3b792ff
user: Carlos Aristu <carlos.aristu <at> openbravo.com>
date: Wed May 29 10:00:12 2019 +0200
summary: related to bug 40721: fix null/undefined check
Replaced "!record[fields[j].name]" with direct checking of null/undefined
values. This is because if having a numeric field populated with a value of 0,
the field was wrongly detected as empty.
diffstat:
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-pickeditgrid.js
| 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diffs (12 lines):
diff -r 7df03a7a83e2 -r 8671a3b792ff
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-pickeditgrid.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-pickeditgrid.js
Wed May 29 07:01:34 2019 +0000
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-pickeditgrid.js
Wed May 29 10:00:12 2019 +0200
@@ -39,7 +39,7 @@
for (i = 0; i < len; i++) {
record = grid.getEditedRecord(grid.getRecordIndex(selection[i]));
for (j = 0; j < fields.length; j++) {
- if (fields[j].required && (!record[fields[j].name] ||
record[fields[j].name] === '')) {
+ if (fields[j].required && (record[fields[j].name] === null ||
record[fields[j].name] === undefined || record[fields[j].name] === '')) {
hasErrors = true;
if (!lineNumbers) {
lineNumbers = grid.getRecordIndex(selection[i]).toString();
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
