On 06/18/2010 07:47 PM, Leo Arias F. wrote: > On 06/18/2010 04:10 AM, Gorka Ion Damián wrote: >> I attach a csv with all the tabs that have changed. The indexes of >> these tabs should be reviewed. >> > > Thanks. Gorka. > Should I add an issue to make the row order consistent? I think that it > would be better to have the id either on the first or on the last > column, but to have it working the same on every grid. However I just > know half of the picture. What do you think?
Hi Leo, i would propose another solution, the index of some internal hidden column is a purely technical detail. Given another way for you to locate this data (see below) i wouldn't spend effort on doing any work on indices. Please take a look at the first request send from the DataGrid.js component on the client side. It contains the complete structure definition of the grid, including names and position of any column present in the grid. Especially the hidden idenfifier column is marked in there. Example from the BusinessPartner selector: <column name="rowkey" identifier="true" visible="false" title="rowkey" type="string" width="0px" sortable=""></column></columns> Accessing that information we cannot only find and use the identifier column but also (if we want) move from the complete indexing scheme to a name based one. This would let us keep the smoketest working if some column would i.e. swap their positions. If that is interesting for you contact me directly for ideas on how to expose the structure information to our SmokeTest classes. Regards, Stefan ------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo _______________________________________________ Openbravo-development mailing list Openbravo-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-development
