From: Pablo Neira Ayuso <[email protected]>

The error message was missing in case of problems bootstrapping the BTS.
The E1 input driver initialization was displayed in the standard output,
now this error is reported via logs.
---
 openbsc/src/libbsc/bsc_init.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/openbsc/src/libbsc/bsc_init.c b/openbsc/src/libbsc/bsc_init.c
index c173c62..ecb4e44 100644
--- a/openbsc/src/libbsc/bsc_init.c
+++ b/openbsc/src/libbsc/bsc_init.c
@@ -439,7 +439,10 @@ int bsc_bootstrap_network(int (*mncc_recv)(struct 
gsm_network *, struct msgb *),
 
        llist_for_each_entry(bts, &bsc_gsmnet->bts_list, list) {
                rc = bootstrap_bts(bts);
-
+               if (rc < 0) {
+                       LOGP(DNM, LOGL_FATAL, "Error bootstrapping BTS\n");
+                       return rc;
+               }
                switch (bts->type) {
                case GSM_BTS_TYPE_NANOBTS:
                case GSM_BTS_TYPE_HSL_FEMTO:
@@ -448,10 +451,9 @@ int bsc_bootstrap_network(int (*mncc_recv)(struct 
gsm_network *, struct msgb *),
                        rc = e1_reconfig_bts(bts);
                        break;
                }
-
                if (rc < 0) {
-                       fprintf(stderr, "Error in E1 input driver setup\n");
-                       exit (1);
+                       LOGP(DNM, LOGL_FATAL, "Error enabling E1 input 
driver\n");
+                       return rc;
                }
        }
 
-- 
1.7.2.3


Reply via email to