On Fri, Feb 24, 2012 at 08:05:10PM +0100, Tobias Engel wrote:
> Hi Harald,
>
> > thanks for your bug analysis and patch. However, I don't really see how
> >
> >> - if (strstr(USSD_TEXT_OWN_NUMBER, req.text) != NULL) {
> >> + if (strcmp(USSD_TEXT_OWN_NUMBER, (const char *) req.text) == 0) {
> >
> > will fix it. What other SS operations include a *#100# in them, so the
> > old code would match on them?
>
> no, the old code matches any _substring_ of "*#100#", including the
> empty string (which is the case if it was a non-USSD-SS operation).
doh! It probably shows that I don't remember having ever used strstr()
in any program myself...
patch applied.
--
- Harald Welte <[email protected]> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
