Hi, Coverity pointed out a missing break. I have added it now but the fix might break BS11 code that relied on this broken functionality.
Could anyone with a BS11 please test this? I will integrate the change in a week. holger >From 41b7e223931e2a9ded16abf95f8ddcb9225ed9b0 Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther <[email protected]> Date: Sun, 14 Jul 2013 07:55:53 +0200 Subject: [PATCH] oml: Add a missing break switch for NM_OC_BS11 It appears to me that for NM_OC_BS11 mo was either NULL or the one mo value from NM_OC_BS11_RACK. The break inside the nested switch case didn't break from the outer one. Fixes Coverity: CID 1040728 --- openbsc/src/libcommon/gsm_data_shared.c | 1 + 1 file changed, 1 insertion(+) diff --git a/openbsc/src/libcommon/gsm_data_shared.c b/openbsc/src/libcommon/gsm_data_shared.c index 9a50f6b..1b0814c 100644 --- a/openbsc/src/libcommon/gsm_data_shared.c +++ b/openbsc/src/libcommon/gsm_data_shared.c @@ -390,6 +390,7 @@ gsm_objclass2mo(struct gsm_bts *bts, uint8_t obj_class, default: return NULL; } + break; case NM_OC_BS11_RACK: mo = &bts->bs11.rack.mo; break; -- 1.8.3.2
