On Sun, Jul 28, 2013 at 01:01:21PM +0200, Andreas Eversberg wrote: > i started splitting the l1sap implementation into parts. the first part > is just cover the BCCH RTS/REQ messages. these are moved from > osmo-bts-sysmo code to common code. i pushed a new branch where i will > commit each part. see last commit of jolly/l1sap_parts branch.
it is still way too big... * e.g... it adds handling for TCH.. when you are just starting with the BCCH... >> primitives left. Avoid creating a thousand lines switch/case >> statement. Modern compilers will nicely inline small static >> methods. * you really don't need to put everything into a single method. Try to put unrelated things into separate methods. Nobody can understand a method that has 1000 lines of codes and tons of if/else in it.
