On Tue, Aug 06, 2013 at 02:29:14PM +0200, Jacob Erlbeck wrote:

Hi,

thanks for compiling with ubuntu and creating a new test. :)

> +/* (C) 2013 by Jacob Erlbeck <[email protected]>
> + * All Rights Reserved

I think you want to use [email protected] and I think something like
... by sysmocom s.f.m.c. Gmbh
Author: Jacob Erlbeck

is approriate.


> +static void init_vty(void)

> +static void free_vty(void)

we can skip that. :)

> +     // check against character strings that could break printf


that is C99/GNU extension. In general we are using the old C comments
with /* */


I will address all of the above before pushinh your patch.

Reply via email to