On Tue, Aug 27, 2013 at 04:52:30PM +0200, Jacob Erlbeck wrote:

>       if (msc->ussd_welcome_txt)
>               vty_out(vty, " bsc-welcome-text %s%s", msc->ussd_welcome_txt, 
> VTY_NEWLINE);
> +     else
> +             vty_out(vty, " no bsc-welcome-text%s", VTY_NEWLINE);

okay, we are in-conistent today about writing out defaults or not.

> +     if (data->ussd_welcome_txt) {
> +             talloc_free(data->ussd_welcome_txt);
> +             data->ussd_welcome_txt = 0;
> +     }

we can skip the conditionals here as well.


holger

Reply via email to