On Thu, Sep 12, 2013 at 11:34:54AM +0400, Alexander Chemeris wrote: > We intend to finish the ACC patch, but it's of lower priority for us > (just like the SMPP DB patch for you). I would appreciate if you > review patches on their own merits.
Dear Alexander, it is not a question of priority. When I review a patch and I find issues (like with the ACC patch, or the nanoBTS init code), I expect to get a follow up patch within reasonable time. In the past this has not happened, or worse, there was an open refusal to increase the quality of the contribution. Please sent follow-up patches in a reasonable time and I will review and merge your changes quickly. holger PS: For this patch the comment is like the ACC patch. Create a VTY unit test that verifies that one can set/unset the policy. Jacob has posted plenty of examples recently.
