Re: [PATCH] db: Add more tests for retrieving subscribers from a DB and avoid NULL dereference when something goes wrong in tests.

[Holger Hans Peter Freyther]

On Sat, Oct 05, 2013 at 12:16:07PM +0200, Alexander Chemeris wrote:
>  #define SUBSCR_PUT(sub) \
> -     sub->net = &dummy_net;  \
> -     subscr_put(sub);
> +     if (sub) { \
> +             sub->net = &dummy_net;  \
> +             subscr_put(sub); \
> +     }

I don't like this semantic change. Either the tests expects a valid
subscriber or it doesn't. It is not a "maybe" this query will result
in a look up.