On Tue, Oct 08, 2013 at 11:28:21AM +0200, Holger Hans Peter Freyther wrote: > On Sun, Oct 06, 2013 at 09:59:28PM +0200, Alexander Huemer wrote: > > > - if (req.text[0] == 0xFF) /* Release-Complete */ > > + if (req.text[0] == '\0') /* Release-Complete */ > > return 0; > > as we can't assume to use the latest libosmocore, what about checking > for both?
Well, as I see it the test against 0xFF is not true under any circumstances, as long as the code is not intentionally compiled with -funsigned-char. If there is an undesired behavior change because of this code change, it's a bug. What's your opinion? Kind regards, -Alex
