On Tue, Oct 22, 2013 at 12:22:39PM +0200, Jacob Erlbeck wrote: Good Morning Jacob!
as usual, the patch looks good! > - nsvc = gprs_nsvc_by_nsei(vty_nsi, nsvci); > + if (!strcmp(id_type, "nsei")) > + nsvc = gprs_nsvc_by_nsei(vty_nsi, id); > + else if (!strcmp(id_type, "nsvci")) > + nsvc = gprs_nsvc_by_nsvci(vty_nsi, id); > + else > + return CMD_WARNING; the VTY will make sure that id_type is either nsei or nsvc. So we can omit the else path. In case you want to keep the else path. I think we should a vty_out with a warning that the given id_type does not exist. I will modify this locally.
