Holger Hans Peter Freyther wrote: dear holger,
thanks for advices. > E.g. in here > #define L1SAP_IS_LINK_SACCH(link_id) ((link_id & 0xC0) == 0x40) > i could change it (and other defines) to something like #define GSM_LINK_ID_SACCH 0x40 #define GSM_LINK_ID_MASK 0xc0 #define L1SAP_IS_LINK_SACCH(link_id) ((link_id & GSM_LINK_ID_MASK) == GSM_LINK_ID_SACCH) is that what you mean by avoiding magic numbers? best regards, andreas
