On Tue, Mar 11, 2014 at 6:26 PM, Holger Hans Peter Freyther <[email protected]> wrote: > On Mon, Mar 10, 2014 at 07:40:51PM +0100, Alexander Chemeris wrote: >> Good idea. An updated patch is attached. > >> +/* DEPRECATED: use gsm340_gen_address_field() instead */ >> +int gsm340_gen_oa(uint8_t *oa, unsigned int oa_len, uint8_t type, >> + uint8_t plan, const char *number) OSMO_DEPRECATED("Use >> gsm340_gen_address_field() instead"); > > this comment doesn't really add any value.
I don't see how it harms either. Though I've removed it in the attached patch. > You are using OSMO_DEPRECTAED > but you do not directly/indirectly the header file defining it. In fact > gsm0411_smc.c fails to compile due this. Oops, forgot to include this in the patch, my apologies. Updated patch is attached. -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. / ООО УмРадио https://fairwaves.co
From 5977b6ed34960171aaf89e8d60f4693953a2c053 Mon Sep 17 00:00:00 2001 From: Alexander Chemeris <[email protected]> Date: Sun, 9 Mar 2014 11:48:16 +0100 Subject: [PATCH] sms: Fix typo in a macros name: GSM340_SMS_RESSERVED -> GSM340_SMS_RESERVED. --- include/osmocom/gsm/protocol/gsm_04_11.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/osmocom/gsm/protocol/gsm_04_11.h b/include/osmocom/gsm/protocol/gsm_04_11.h index f37152f..38dd553 100644 --- a/include/osmocom/gsm/protocol/gsm_04_11.h +++ b/include/osmocom/gsm/protocol/gsm_04_11.h @@ -122,7 +122,7 @@ enum sms_alphabet { #define GSM340_SMS_COMMAND_MS2SC 0x02 #define GSM340_SMS_SUBMIT_MS2SC 0x01 #define GSM340_SMS_SUBMIT_REP_SC2MS 0x01 -#define GSM340_SMS_RESSERVED 0x03 +#define GSM340_SMS_RESERVED 0x03 /* GSM 03.40 / Chapter 9.2.3.2: TP-More-Messages-to-Send */ #define GSM340_TP_MMS_MORE 0 -- 1.7.9.5
