On Wed, Mar 12, 2014 at 8:09 PM, Daniel Willmann <[email protected]> wrote: > Hello Alexander, > > On Fri, 2014-03-07 at 21:15, Alexander Chemeris wrote: >> From 13d7321d553b920b4b66d4c7d8f6f20c82bc3459 Mon Sep 17 00:00:00 2001 >> From: Alexander Chemeris <[email protected]> >> Date: Fri, 7 Mar 2014 20:42:03 +0100 >> Subject: [PATCH 2/6] sms_test: Do not crash on logging. >> >> --- >> tests/sms/sms_test.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/tests/sms/sms_test.c b/tests/sms/sms_test.c >> index 755b321..cd21e92 100644 >> --- a/tests/sms/sms_test.c >> +++ b/tests/sms/sms_test.c >> @@ -31,6 +31,10 @@ >> #include <osmocom/core/msgb.h> >> #include <osmocom/core/utils.h> >> >> +#include <osmocom/core/logging.h> >> + >> +struct log_info fake_log_info = {}; >> + >> struct test_case { >> const uint8_t *input; >> const uint16_t input_length; >> @@ -278,6 +282,9 @@ int main(int argc, char** argv) >> int nchars; >> char result[256]; >> >> + /* Fake logging. */ >> + osmo_init_logging(&fake_log_info); > > osmo_init_logging() is declared in include/osmocom/core/application.h
Fixed, thanks. I don't like this fact that in C it's possible to use a non-defined function and it's just a warning. -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. / ООО УмРадио https://fairwaves.co
From 190feef753fd271f3668d0a55cd5edd0215021bf Mon Sep 17 00:00:00 2001 From: Alexander Chemeris <[email protected]> Date: Fri, 7 Mar 2014 20:42:03 +0100 Subject: [PATCH 2/6] sms_test: Do not crash on logging. --- tests/sms/sms_test.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/sms/sms_test.c b/tests/sms/sms_test.c index 755b321..30ce1f4 100644 --- a/tests/sms/sms_test.c +++ b/tests/sms/sms_test.c @@ -31,6 +31,11 @@ #include <osmocom/core/msgb.h> #include <osmocom/core/utils.h> +#include <osmocom/core/logging.h> +#include <include/osmocom/core/application.h> + +struct log_info fake_log_info = {}; + struct test_case { const uint8_t *input; const uint16_t input_length; @@ -278,6 +283,9 @@ int main(int argc, char** argv) int nchars; char result[256]; + /* Fake logging. */ + osmo_init_logging(&fake_log_info); + /* test 7-bit encoding */ for (i = 0; i < ARRAY_SIZE(test_encode); ++i) { /* Test legacy function (return value only) */ -- 1.7.9.5
